Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Dec 2020 11:05:56 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 1622a498525b - No need to stop XHCI endpoints in disabled state.
Message-ID:  <202012231105.0BNB5uYI049801@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by hselasky:

URL: https://cgit.FreeBSD.org/src/commit/?id=1622a498525b4ef0d23d30a587b9a3888c3ee0d5

commit 1622a498525b4ef0d23d30a587b9a3888c3ee0d5
Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2020-12-23 10:54:42 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2020-12-23 11:04:51 +0000

    No need to stop XHCI endpoints in disabled state.
    
    Some AMD XHCI implementations apparently assert a permanent
    internal failure if this happens.
    
    Submitted by:   ali.abdallah@suse.com
    PR:             251503
    MFC after:      1 week
    Sponsored by:   Mellanox Technologies // NVIDIA Networking
---
 sys/dev/usb/controller/xhci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sys/dev/usb/controller/xhci.c b/sys/dev/usb/controller/xhci.c
index 1f8877546c27..10e37c97c254 100644
--- a/sys/dev/usb/controller/xhci.c
+++ b/sys/dev/usb/controller/xhci.c
@@ -3870,6 +3870,8 @@ xhci_configure_reset_endpoint(struct usb_xfer *xfer)
 	 * endpoint context state diagram in the XHCI specification:
 	 */
 	switch (xhci_get_endpoint_state(udev, epno)) {
+	case XHCI_EPCTX_0_EPSTATE_DISABLED:
+                break;
 	case XHCI_EPCTX_0_EPSTATE_STOPPED:
 		break;
 	case XHCI_EPCTX_0_EPSTATE_HALTED:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202012231105.0BNB5uYI049801>