From owner-freebsd-mono@freebsd.org Tue Dec 15 23:20:11 2020 Return-Path: Delivered-To: freebsd-mono@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BDDA04A8083 for ; Tue, 15 Dec 2020 23:20:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CwZ3v4j3bz3M8Z for ; Tue, 15 Dec 2020 23:20:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9F7ED4C7C31; Tue, 15 Dec 2020 23:20:11 +0000 (UTC) Delivered-To: mono@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F4404A8082 for ; Tue, 15 Dec 2020 23:20:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CwZ3v3YWWz3MFL for ; Tue, 15 Dec 2020 23:20:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6CFB91C55F for ; Tue, 15 Dec 2020 23:20:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0BFNKBHF014517 for ; Tue, 15 Dec 2020 23:20:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0BFNKBHM014516 for mono@FreeBSD.org; Tue, 15 Dec 2020 23:20:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: mono@FreeBSD.org Subject: [Bug 238089] lang/mono: Update to 5.20 (5.10.0 dates to 2018-02) Date: Tue, 15 Dec 2020 23:20:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: a13xlevy@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mono@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-mono@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Mono and C# applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 23:20:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238089 --- Comment #78 from Alex Levy --- (In reply to Mark Linimon from comment #77) I gave a try to reformat to be as close as the original Makefile but my Makefile is drastically different than the original one as it's based on pulling the sources from github and the buid process is different. Also order of things in the original Makefile doesn't follow the porter's handbook recommendation (section 15), not sure if it's a blocker but portli= nt complains about it so I ordered my Makefile accordingly. I don't think we can easily compare the 2 Makefiles with a diff even if I change indentation and order of things. I can instead explain the differenc= es here if it helps (in order of appearance in the original Makefile) : - I removed ONLY_FOR_ARCHS as I cannot say for sure that it builds on these platforms. - The dependencies are almost the same except there is no need for run dependency on PY_PILLOW and no dependency at all on Perl. - No need for a MONOLITE option (${GMAKE} get-monolite-latest in pre-build covers it). - I removed the X11 option as configure script doesn't seem to expose any related parameters. - I added DTRACE and BTLS options but they were not required per-se. The original Makefile was configuring with --enable-btls and --disable-dtrace hardcoded. - GNU_CONFIGURE, LD_CONFIG are same - SHEBANG_FILES differs because paths of scripts are different - USE_PERL5, BINARY_ALIAS, MAKE_ENV, TEST_* and PORTSCOUT (should I keep th= is one?) are gone.=20 - No need for the conditional on ${LOCALBASE}/bin/mcs. - I added a pre-build that fetches monolite as instructed in https://www.mono-project.com/docs/compiling-mono/compiling-from-git/ - There is no post-patch, no post-configure and no post-extract*=20 - post-install is the same, I just strip libmono-btls-shared.so as INSTALL_TARGET=3Dinstall-strip didn't do the trick for this one. Hope that it helps. --=20 You are receiving this mail because: You are the assignee for the bug.=