From owner-freebsd-ports@FreeBSD.ORG Fri Nov 22 13:20:57 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B55BEE71 for ; Fri, 22 Nov 2013 13:20:57 +0000 (UTC) Received: from mail-we0-x236.google.com (mail-we0-x236.google.com [IPv6:2a00:1450:400c:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4CD7E2437 for ; Fri, 22 Nov 2013 13:20:57 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id q59so1155022wes.27 for ; Fri, 22 Nov 2013 05:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=4NSYwn0ms4sUJcmh9ihww6b9z/rFEfYQQ18Q/uQcFGo=; b=MukS0LkMVRnXJWm8TqqytL/0cMYS/BU1t8vCvTg5g2CQZmJFGIbHdKUlhxe3iGsE/6 uWJeooCKKLYGMvQgf6P/w03nm/3FRUf/jlv+hjU9OoGqcRPnLSIFrJiniFdrq6xGAJV8 8PJyc8DndrPvw1domKPhp9CZy1z4tbl2dFFATmbdxTAxXLD2oEzvRS3N8T34J7lsrPcI 8wMfNLwtPgKbRT8Kq7RfyNQrXFoc/kzXZU76U3pd7HtDKeLbUKCDmK1FNQrlYosWo5NG JamEHw6lTHtVhc0ZFbo9ZCO6/fo2u7Ag5YC7PXaiNqKCboQzfIeinVAbA3HO+/mWer8F fZJg== X-Received: by 10.194.175.66 with SMTP id by2mr1231281wjc.59.1385126455641; Fri, 22 Nov 2013 05:20:55 -0800 (PST) Received: from ?IPv6:2001:14b8:100:8321::10? ([2001:14b8:100:8321::10]) by mx.google.com with ESMTPSA id uc12sm15792758wib.3.2013.11.22.05.20.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 22 Nov 2013 05:20:54 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: DESTDIR support broken? From: Paasiala Kimmo In-Reply-To: <20131122131727.GB7437@straylight.m.ringlet.net> Date: Fri, 22 Nov 2013 15:20:50 +0200 Message-Id: References: <52850FBA.9010308@bsdforen.de> <5289CA5E.3010103@bsdforen.de> <528BA37E.4030308@bsdforen.de> <528F55E4.3040602@bsdforen.de> <20131122131727.GB7437@straylight.m.ringlet.net> To: Peter Pentchev X-Mailer: Apple Mail (2.1822) Cc: FreeBSD Ports , Dominic Fandrey , Eitan Adler X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 13:20:57 -0000 --Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 22.11.2013, at 15.17, Peter Pentchev wrote: > On Fri, Nov 22, 2013 at 02:02:28PM +0100, Dominic Fandrey wrote: >> On 19/11/2013 18:44, Dominic Fandrey wrote: >>> On 18/11/2013 20:28, Kimmo Paasiala wrote: >>>> On Mon, Nov 18, 2013 at 10:05 AM, Dominic Fandrey = wrote: >>>>> On 18/11/2013 04:10, Eitan Adler wrote: >>>>>> On Thu, Nov 14, 2013 at 1:00 PM, Dominic Fandrey = wrote: >>>>>>> # make DESTDIR=3D/root/tmpdest install >>>>>>> =3D=3D=3D> Creating some important subdirectories >>>>>>=20 >>>>>> Are you sure you don't mean "make PREFIX=3D/root/tmpdest/" ? >>>>>=20 >>>>> Yes. >>>>>=20 >>>>> -- >>>>=20 >>>> I would expect DESTDIR=3D/some/path just work for any port. Last = commit >>>> to bsd.destdir was over a year ago so either it has been broken for = a >>>> long time or some other more recent commit has broken it. >>>=20 >>> /root/tmpdest is a complete FreeBSD chroot (I did a >>> "make installworld distribution DESTDIR=3D/root/tmpdest" right = beforehand). >>>=20 >>> I tried several ports, they all exhibit the same failure. >>=20 >> The issue is that BSD make (in stable/10) passes "set -e" to the = shell >> by default. >>=20 >> I submitted the details and a fix: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D184170 >=20 > Hmm, even if this is so, I wonder if there would not be another funny > problem later: for ports that actually use staging, bsd.stage.mk tries > to pass a DESTDIR of its own to upstream's build system, so the = DESTDIR > specified on the make(1) command line might not be passed to = upstream's > build system at all. So bsd.destdir.mk might do its thing, but then > bsd.stage.mk would override the DESTDIR setting during the actual = build > and installation of the upstream sources, so I wonder if anything at = all > would be installed into the chroot. >=20 > G'luck, > Peter >=20 As far as I know the temporary setting of DESTDIR to the stagedir is in = effect only during =91make stage=92 so during =91make install=92 your = own custom DESTDIR should be respected. -Kimmo --Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJSj1oyAAoJEFvLZC0FWRVpX8gIALZ0QDBN1IsNTp0zXIkcKWtS df8g6EdqXX74yNB6VhGD6dGG32HyhQrApQpdFBhFt6Ev+spd46NiKu6RW1THCtbz PKMQt9+4i61bpPatix/Qp+X80ZCoqADbHzKoT9H8epMP7ZeOeuCyIeKoEZKHUDFf UcUm5m8KAymoiBQrzzKVaD1Qj/qIFHlShVo6+1qNPZC8YeKsq61Hw7dYu7HXqsj1 hIZmC06hZH7KqUPvR9FTe5NdWgJw/2XXV9wNSCVisVDCGK3G03v1uYKlMUPHu3Md O3wRbRAY6avy6pI1cPhi4i+ZOIHXZjxrvPX3FWQMtW072MTHh3TG6wjJFMgDGkg= =c6Mw -----END PGP SIGNATURE----- --Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D--