From owner-svn-ports-all@FreeBSD.ORG  Tue Jun 10 06:52:12 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 0EDC2B89; Tue, 10 Jun 2014 06:52:12 +0000 (UTC)
Date: Tue, 10 Jun 2014 06:52:12 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Greg Lewis <glewis@FreeBSD.org>
Subject: Re: svn commit: r357248 - in head/games/moria: . files
Message-ID: <20140610065212.GC89864@FreeBSD.org>
References: <201406100322.s5A3MOVY012329@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201406100322.s5A3MOVY012329@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2014 06:52:12 -0000

On Tue, Jun 10, 2014 at 03:22:24AM +0000, Greg Lewis wrote:
> New Revision: 357248
> URL: http://svnweb.freebsd.org/changeset/ports/357248
> QAT: https://qat.redports.org/buildarchive/r357248/
> 
> +MAKE_ENV+=	DOCSDIR="${DOCSDIR}" MKDIR="${MKDIR}" TOUCH="${TOUCH}" \
> +		STAGEDIR="${STAGEDIR}" DATADIR="${DATADIR}"

What's wrong with default DESTDIR?

> -+	${MKDIR} ${DOCSDIR}
> -+	${BSD_INSTALL_DATA} ${FILES} ${DOCSDIR}
> ++	${MKDIR} ${STAGEDIR}${DOCSDIR}
> ++	${BSD_INSTALL_DATA} ${FILES} ${STAGEDIR}${DOCSDIR}

That should be used here instead of STAGEDIR.  Not just it would allow you
do drop that from MAKE_ENV/ARGS, it would also make it easier to integrate
these patches back upstream (DESTDIR is standard name, STAGEDIR is not).

./danfe