From owner-freebsd-hackers@freebsd.org Wed Jun 13 10:29:39 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 615AD101D820 for ; Wed, 13 Jun 2018 10:29:39 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x229.google.com (mail-yb0-x229.google.com [IPv6:2607:f8b0:4002:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 027F9799CB for ; Wed, 13 Jun 2018 10:29:38 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x229.google.com with SMTP id x36-v6so727423ybi.0 for ; Wed, 13 Jun 2018 03:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=7qlUGokNvB82NoRe8/Oe8lGhDPG0ZnR5C9TXEsuZ5pI=; b=Ip1G0EluKIu4SUBhDBTxdcxsmiMuTgnILC5OT6iL7zMMkaZGwfDIg16D79ny7brUAO x7//hxA6HIJ3tH/k+BhRgtP8uleAgBX84/Uz9orWSSd7KwnqMlrEdxvFcgLFOzdn8v7o jfNgKSLWUh/CuOaCIeyYBTe1ZvWwUYMiCtaCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=7qlUGokNvB82NoRe8/Oe8lGhDPG0ZnR5C9TXEsuZ5pI=; b=QYB+7r5Uf7bRoF+3ZiivT9pCRTdqS0LUkh4owEZ0YxCPqersMA5m7CyaQa+rvrffUv nijl5eaGOHmOf4MSr04hA/H3mZgFD4RK75xhtgYrC8sgWTB9uylE6UpCArvTFCSBt1qD 1eGcg6pVgRBCkbs458jAJHz2nPbz7epYaPY5VBb/++byedBcB1Q6PteGJ18Vv3yMVMOZ BIb24gFUFn4uqedyVIwSzx41+DfthietuXxXdAOEHcjKIen3jL5q1gxhBtULOIfqiE2K bKdWVj2/CdWIN3QlKravJnrAycBWHK0iReaWcEJn7XNVq8iokl6/kfil3k8vsfHuEgLC 45VQ== X-Gm-Message-State: APt69E3PUtKkG21c+rV1h0J2vHfN6sd4tB41yOkm/VoXgwx24GOB9yhy G+4pTrMAV6+UviOcKpaWRhgX5/UpQLPfC3VLY8BFBz8g X-Google-Smtp-Source: ADUXVKJf0FzCGsK8/zxY8F8O/Q81PKpkt01jHAnMVzES1IdasQuk0rT4rUROoS5GdqhwEvZ0fa8DzYP/HdoarkjZrdA= X-Received: by 2002:a25:bd41:: with SMTP id p1-v6mr1918510ybm.69.1528885778251; Wed, 13 Jun 2018 03:29:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 03:29:07 -0700 (PDT) In-Reply-To: References: <20180317173815.GM75576@funkthat.com> From: Eitan Adler Date: Wed, 13 Jun 2018 03:29:07 -0700 Message-ID: Subject: Re: gf128_add can be marked as __pure2 To: Eitan Adler , John Baldwin , FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 10:29:39 -0000 On 17 March 2018 at 11:38, Eitan Adler wrote: > On 17 March 2018 at 10:38, John-Mark Gurney wrote: >> Eitan Adler wrote this message on Mon, Feb 19, 2018 at 19:15 -0800: >>> Is there any reason not to apply this patch? >> >> I don't see why there wouldn't be.. >> >>> __pure2 means __attribute__((const)) which is correct in this case as >>> gf128_add read no global memory: For extra clarity, since this is crypto related, can you please accept here: https://reviews.freebsd.org/D15786 -- Eitan Adler