From owner-svn-src-all@FreeBSD.ORG Mon Aug 25 17:02:47 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 474C0FEB; Mon, 25 Aug 2014 17:02:47 +0000 (UTC) Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com [IPv6:2a00:1450:400c:c05::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 412D83193; Mon, 25 Aug 2014 17:02:46 +0000 (UTC) Received: by mail-wi0-f170.google.com with SMTP id f8so3993789wiw.5 for ; Mon, 25 Aug 2014 10:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=zEBhwwUVGN1kXZlyO+ztYDnCWBnbOHMO+qrQmXy6RjQ=; b=PlEHQQ+lmUgzh2AJqK+n2NToW2v3KDp/pyom4YW0n3zwHVx1awOGoaYg5krCi6lrk8 KptnEmGIi78ugOe42tmOLnue6zH37kvHLKDikQitAnHhEZJhkT++2VQl4ybJxI4Cqf+/ URXP/trC+Or/Zd4iMoQ1MdXN+VzSOlTc4K3pIq3hE1/QBxIwyff3yOUak1M25RVJ3DoS RgrSs5PEyRlchkGmn2aPo4wDzcZhxBQKQKF/6agWXr8p729Qixvzm0t796LvJ5vdMcgb XSkj8qoWzdcfumRyaOKfXgADV8DgbK6GlIY+BarmVuKOmP7495itOtrmpRcFc9zna/Ei cfSA== X-Received: by 10.180.92.73 with SMTP id ck9mr16910639wib.54.1408986164500; Mon, 25 Aug 2014 10:02:44 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id k10sm979336wjb.28.2014.08.25.10.02.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 25 Aug 2014 10:02:43 -0700 (PDT) Date: Mon, 25 Aug 2014 19:02:41 +0200 From: Mateusz Guzik To: John Baldwin Subject: Re: svn commit: r270444 - in head/sys: kern sys Message-ID: <20140825170241.GA23088@dft-labs.eu> References: <201408240904.s7O949sI083660@svn.freebsd.org> <1724027.iWxFDWcg2R@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1724027.iWxFDWcg2R@ralph.baldwin.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 17:02:47 -0000 On Mon, Aug 25, 2014 at 10:23:19AM -0400, John Baldwin wrote: > On Sunday, August 24, 2014 09:04:09 AM Mateusz Guzik wrote: > > Author: mjg > > Date: Sun Aug 24 09:04:09 2014 > > New Revision: 270444 > > URL: http://svnweb.freebsd.org/changeset/base/270444 > > > > Log: > > Fix getppid for traced processes. > > > > Traced processes always have the tracer set as the parent. > > Utilize proc_realparent to obtain the right process when needed. > > Are you sure this won't break things? I know of several applications that > expect a debugger to be the parent when attached and change behavior as a > result (e.g. inserting a breakpoint on an assertion failure rather than > generating a core). > Well, this is what linux and solaris do. I don't feel strongly about this change. If you really want I'm happy to revert. -- Mateusz Guzik