From owner-freebsd-current@FreeBSD.ORG  Tue Sep 14 05:09:43 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5C8A116A4CE
	for <current@freebsd.org>; Tue, 14 Sep 2004 05:09:43 +0000 (GMT)
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 21F8043D54
	for <current@freebsd.org>; Tue, 14 Sep 2004 05:09:43 +0000 (GMT)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.9p2/8.12.9) with ESMTP id i8E59evA001665
	for <current@freebsd.org>; Mon, 13 Sep 2004 22:09:42 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.9p2/8.12.9/Submit) id i8E59epB001664;
	Mon, 13 Sep 2004 22:09:40 -0700 (PDT)
	(envelope-from dillon)
Date: Mon, 13 Sep 2004 22:09:40 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200409140509.i8E59epB001664@apollo.backplane.com>
To: current@freebsd.org
Subject: Possible bug in softclock()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Sep 2004 05:09:43 -0000

    In softclock(), should this line:

	c->c_flags = (c->c_flags & ~CALLOUT_PENDING);

    be:

	c->c_flags = (c->c_flags & ~(CALLOUT_PENDING | CALLOUT_MPSAFE));

    ?

    Otherwise routines which call callout_reset() to reset the callout
    will always clear the CALLOUT_MPSAFE flag.  This won't hurt things,
    but it will make them more inefficient.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>