From owner-freebsd-audit Thu May 16 6: 2:20 2002 Delivered-To: freebsd-audit@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id C572137B409 for ; Thu, 16 May 2002 06:02:16 -0700 (PDT) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 0362D5307; Thu, 16 May 2002 15:02:13 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Giorgos Keramidas Cc: Peter Pentchev , Bruce Evans , Mike Makonnen , freebsd-audit@FreeBSD.ORG Subject: Re: RFC: Port of NetBSD cat(1)'s -f option. References: <20020515211758.GB68380@hades.hell.gr> <20020516164332.B1704-100000@gamplex.bde.org> <20020516134044.A349@straylight.oblivion.bg> <20020516152345.E349@straylight.oblivion.bg> <20020516124343.GA93634@hades.hell.gr> From: Dag-Erling Smorgrav Date: 16 May 2002 15:02:13 +0200 In-Reply-To: <20020516124343.GA93634@hades.hell.gr> Message-ID: Lines: 15 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Giorgos Keramidas writes: > I'm not sure. The < 0 check is almost hardwired in my fingers, > because of a few years of writing it this way. Just trying to be on > the safe side of the world, I guess. It's also a single instruction (+ a flag check) on most architectures, while an explicit comparison is at least two, and possibly trashes a register. That being said, I use == -1 myself - but I don't think < 0 is wrong, just different. As long as we're consistent, I don't care. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message