Skip site navigation (1)Skip section navigation (2)
Date:      16 May 2002 15:02:13 +0200
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        Giorgos Keramidas <keramida@ceid.upatras.gr>
Cc:        Peter Pentchev <roam@ringlet.net>, Bruce Evans <bde@zeta.org.au>, Mike Makonnen <makonnen@pacbell.net>, freebsd-audit@FreeBSD.ORG
Subject:   Re: RFC: Port of NetBSD cat(1)'s -f option.
Message-ID:  <xzpptzwtfe2.fsf@flood.ping.uio.no>
In-Reply-To: <20020516124343.GA93634@hades.hell.gr>
References:  <20020515211758.GB68380@hades.hell.gr> <20020516164332.B1704-100000@gamplex.bde.org> <20020516134044.A349@straylight.oblivion.bg> <xzpznz0thma.fsf@flood.ping.uio.no> <20020516152345.E349@straylight.oblivion.bg> <20020516124343.GA93634@hades.hell.gr>

next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> I'm not sure.  The < 0 check is almost hardwired in my fingers,
> because of a few years of writing it this way.  Just trying to be on
> the safe side of the world, I guess.

It's also a single instruction (+ a flag check) on most architectures,
while an explicit comparison is at least two, and possibly trashes a
register.

That being said, I use == -1 myself - but I don't think < 0 is wrong,
just different.  As long as we're consistent, I don't care.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpptzwtfe2.fsf>