From owner-cvs-all Mon Jul 8 15:46: 5 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A702537B400; Mon, 8 Jul 2002 15:46:01 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57B1D43E31; Mon, 8 Jul 2002 15:46:01 -0700 (PDT) (envelope-from luigi@FreeBSD.org) Received: from freefall.freebsd.org (luigi@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g68Mk1JU016111; Mon, 8 Jul 2002 15:46:01 -0700 (PDT) (envelope-from luigi@freefall.freebsd.org) Received: (from luigi@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g68Mk15p016110; Mon, 8 Jul 2002 15:46:01 -0700 (PDT) Message-Id: <200207082246.g68Mk15p016110@freefall.freebsd.org> From: Luigi Rizzo Date: Mon, 8 Jul 2002 15:46:01 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet ip_fw2.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG luigi 2002/07/08 15:46:01 PDT Modified files: sys/netinet ip_fw2.c Log: No functional changes, but: Following Darren's suggestion, make Dijkstra happy and rewrite the ipfw_chk() main loop removing a lot of goto's and using instead a variable to store match status. Add a lot of comments to explain what instructions are supposed to do and how -- this should ease auditing of the code and make people more confident with it. In terms of code size: the entire file takes about 12700 bytes of text, about 3K of which are for the main function, ipfw_chk(), and 2K (ouch!) for ipfw_log(). Revision Changes Path 1.4 +266 -278 src/sys/netinet/ip_fw2.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message