From owner-cvs-all@FreeBSD.ORG Tue Dec 14 09:09:39 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90F7810666E7; Tue, 14 Dec 2010 09:09:39 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from vms173005pub.verizon.net (vms173005pub.verizon.net [206.46.173.5]) by mx1.freebsd.org (Postfix) with ESMTP id 6645C8FC1E; Tue, 14 Dec 2010 09:09:39 +0000 (UTC) Received: from [192.168.1.8] ([unknown] [173.70.194.135]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LDE00259RZL5200@vms173005.mailsrvcs.net>; Tue, 14 Dec 2010 02:09:26 -0600 (CST) Message-id: <4D07262A.3020303@aldan.algebra.com> Date: Tue, 14 Dec 2010 03:09:14 -0500 From: "Mikhail T." User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; uk-UA; rv:1.9.2.12) Gecko/20101114 Thunderbird/3.1.6 MIME-version: 1.0 To: Alexey Dokuchaev References: <201012140611.oBE6B42j028412@repoman.freebsd.org> <20101214072748.GA70334@FreeBSD.org> In-reply-to: <20101214072748.GA70334@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports GIDs UIDs ports/net Makefile ports/net/minidlna Makefile distinfo pkg-descr pkg-plist ports/net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch-aa patch-ab patch-inline patch-minidlna.c patch-upnphttp ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2010 09:09:39 -0000 On 14.12.2010 02:27, Alexey Dokuchaev wrote: > On Tue, Dec 14, 2010 at 06:11:04AM +0000, Mikhail Teterin wrote: >> mi 2010-12-14 06:11:04 UTC >> >> Added files: >> net/minidlna Makefile distinfo pkg-descr pkg-plist >> net/minidlna/files BSDmakefile config.h getifaddr.c >> minidlna.sh.in patch-2928850 patch-aa >> patch-ab patch-inline patch-minidlna.c >> patch-upnphttp pkg-message.in >> scandir-patch >> Log: >> Add the port of minidlna -- the DLNA-speaking service. >> (Took me 6 months to come up with the etc/rc.d/ script...) > It's sad that during these 6 months you did not find few minutes to ask > dougb@ to review it. Why is dougb@ to be burdened reviewing these particular things? Having done the actual heavy-lifting of porting this Linux-only piece of software back in June, I published the port's shar and asked -- on ports@ -- for somebody else to contribute the start-up script. For 6 months no one has and now, finally, got around to learning, how to do this myself. >> Revision Changes Path >> 1.1 +11 -0 ports/net/minidlna/files/patch-aa (new) >> 1.1 +9 -0 ports/net/minidlna/files/patch-ab (new) > Apart from number of style bugs in the Makefile, can you explain why did Portlint's only complaint is the single MASTER_SITE... Feel free to submit patches. > you go with `patch-xy' files, which is against current naming policy? Because I felt like this color was matching this bike shed the best... Because several naming styles exist currently and this particular one reminds the audience of the good old times, when new ports -- especially those, which provide unique and hitherto unavailable functionality -- were welcomed, rather than scolded for imaginary transgressions... You are welcome. -mi