Date: Sun, 15 Oct 2006 01:15:02 +0200 From: Rink Springer <rink@FreeBSD.org> To: Bruce Evans <bde@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_vnops.c Message-ID: <20061014231502.GA38708@rink.nu> In-Reply-To: <200610140725.k9E7PC37008454@repoman.freebsd.org> References: <200610140725.k9E7PC37008454@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bruce, On Sat, Oct 14, 2006 at 07:25:12AM +0000, Bruce Evans wrote: > bde 2006-10-14 07:25:12 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/nfsclient nfs_vnops.c=20 > Log: > Don't do null Setattr RPCs for VA_MARK_ATIME. When we added the > VA_MARK_ATIME feature to fix POSIX conformance fore execve() and mmap(), > we thought that it was optimized well enough for the one file system > that supports it (ffs) and harmless for other file systems (except > layered ones which already get the layering for VOP_SETATTR() wrong). > However, nfs_setattr() doesn't do much parameter checking, so when > it gets a combination of parameters that it doesn't understand, it > always does a Setattr RPC. This RPC can't do anything good, and for > VA_MARK_ATIME it is null except for wasting a lot of time. > =20 > This is the smallest and easiest to fix of several bugs that have > increased the number of RPCs for kernel builds on nfs by more than > 100% since 2004-11-05. The real-time increase depends on network > latency and parallelization and can also be very large (approaching > the same percentage for unparallelized operations like "make depend" > on systems with fast CPUs and high-latency networks). > =20 > Revision Changes Path > 1.270 +2 -2 src/sys/nfsclient/nfs_vnops.c The code in RELENG_6 looks as if it would benefit from this change as well. Do you have a MFC planned in the nearby future? --=20 Rink P.W. Springer - http://rink.nu "Patience is for those who cannot afford decent hardware." - Peter Koeleman --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFMW92b3O60uztv/8RAirVAKCknWURmJix6dc8FskoK5ycJlssQwCeLw98 nYcbvHIaivjFBjnFNHy9Xhw= =Zbys -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061014231502.GA38708>