From owner-svn-src-head@FreeBSD.ORG Wed May 13 20:25:33 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 075EA106567D for ; Wed, 13 May 2009 20:25:33 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id AB94E8FC1E for ; Wed, 13 May 2009 20:25:32 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id A875D8FC51 for ; Thu, 14 May 2009 00:25:31 +0400 (MSD) Received: from orion.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id B879E8FC18; Thu, 14 May 2009 00:25:28 +0400 (MSD) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 2AD7139830; Thu, 14 May 2009 00:25:55 +0400 (MSD) Date: Thu, 14 May 2009 00:25:55 +0400 From: Stanislav Sedov To: Oleksandr Tymoshenko Message-Id: <20090514002555.f56ba38b.stas@FreeBSD.org> In-Reply-To: <200905131842.n4DIgnnu064429@svn.freebsd.org> References: <200905131842.n4DIgnnu064429@svn.freebsd.org> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Thu May 14 00:25:31 2009 X-DSPAM-Confidence: 0.9899 X-DSPAM-Improbability: 1 in 9809 chance of being spam X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 4a0b2cbb994291963314094 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r192059 - in head/sys: arm/at91 dev/spibus X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2009 20:25:33 -0000 On Wed, 13 May 2009 18:42:49 +0000 (UTC) Oleksandr Tymoshenko mentioned: > Author: gonzo > Date: Wed May 13 18:42:49 2009 > New Revision: 192059 > URL: http://svn.freebsd.org/changeset/base/192059 > > Log: > - Make SPI bus bridge be non-arch dependent by using more generic > name > > Reviewed by: imp > > Modified: > head/sys/arm/at91/at91_spi.c > head/sys/dev/spibus/spibus.c > > Modified: head/sys/arm/at91/at91_spi.c > ============================================================================== > --- head/sys/arm/at91/at91_spi.c Wed May 13 18:31:28 2009 (r192058) > +++ head/sys/arm/at91/at91_spi.c Wed May 13 18:42:49 2009 (r192059) > @@ -297,7 +297,7 @@ static device_method_t at91_spi_methods[ > }; > > static driver_t at91_spi_driver = { > - "at91_spi", > + "spi", > at91_spi_methods, > sizeof(struct at91_spi_softc), > }; > > Modified: head/sys/dev/spibus/spibus.c > ============================================================================== > --- head/sys/dev/spibus/spibus.c Wed May 13 18:31:28 2009 (r192058) > +++ head/sys/dev/spibus/spibus.c Wed May 13 18:42:49 2009 (r192059) > @@ -194,5 +194,5 @@ static driver_t spibus_driver = { > > devclass_t spibus_devclass; > > -DRIVER_MODULE(spibus, at91_spi, spibus_driver, spibus_devclass, 0, 0); > +DRIVER_MODULE(spibus, spi, spibus_driver, spibus_devclass, 0, 0); > MODULE_VERSION(spibus, 1); > On the other hand this driver appears to be machine-specific. What if one would like to have a kernel with several SPI bus drivers included for devices that doesn't support enumeration? In this case it will be impossible to diffirentiate these drivers in the hints file. -- Stanislav Sedov ST4096-RIPE !DSPAM:4a0b2cbb994291963314094!