From owner-freebsd-scsi Thu Jan 16 12: 6: 4 2003 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FDDB37B401; Thu, 16 Jan 2003 12:06:04 -0800 (PST) Received: from cleitus.hosting.swbell.net (cleitus.hosting.swbell.net [216.100.99.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D46243E4A; Thu, 16 Jan 2003 12:06:03 -0800 (PST) (envelope-from alc@imimic.com) Received: from imimic.com (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) by cleitus.hosting.swbell.net id PAA00814; Thu, 16 Jan 2003 15:05:55 -0500 (EST) [ConcentricHost SMTP Relay 1.14] Message-ID: <3E2710A2.97A2BB07@imimic.com> Date: Thu, 16 Jan 2003 14:05:54 -0600 From: "Alan L. Cox" Organization: iMimic Networking, Inc. X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386) X-Accept-Language: en MIME-Version: 1.0 To: Matthew Dillon Cc: scsi@freebsd.org, gibbs@freebsd.org, Tor.Egge@cvsup.no.freebsd.org Subject: Re: vmapbuf() changes effect CAM (patch) References: <200301160225.h0G2PE21019224@apollo.backplane.com> Content-Type: text/plain; charset=x-user-defined Content-Transfer-Encoding: 7bit Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Matthew Dillon wrote: > ... > Alan, Tor, if you could review the whole patch I would appreciate it. > Note that this is an incremental patch, it fixes the vmapbuf() race but > does not yet clean up the useracc() checks (to just check that the > address range is within the user VM space rather then also checking > the map entries). > You must hold the page queues lock around vm_page_unhold(). You might as well add similar locking around vm_page_hold(). Although at present, it won't trip an assertion. Alan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message