From owner-svn-src-head@freebsd.org Thu Sep 28 06:53:50 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5E28E2AAAE; Thu, 28 Sep 2017 06:53:50 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com [IPv6:2607:f8b0:400d:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F85B72739; Thu, 28 Sep 2017 06:53:50 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-qk0-x22b.google.com with SMTP id u67so501272qkg.6; Wed, 27 Sep 2017 23:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=yB8X9R2+ooKakv1gqRRusVDb5msog6XMaORS10eiMiY=; b=R3PiIdO9n6UGaLYjIx0U3Zs8tQlac6GXAbp7QkmGLxdCkof59YF4n4Oh3uQ4eEjz05 NDGCsIfAUGHCN5lDvuu3vB+FY4LZ83ZlHOg7S30SLJut4hGbR+whL2cSFHavDP2hEuzi qv5wdbaZHYBb+UVc0UMOa6lCgASx0s9DupM0IglHePqNTzokE8Xvjzvq49y3nOyDGrMB 11uUKvPyLaEXqZO4M+pKGohAm/E4yTQpGu3RnDMsWpmbGUrBvRoGpq3dfY6W6GPWumpV 844vsqVzVdKtbg1cph2ztQ9A8NLo9NY7E36jyKG6jX5cNotBduEm5Zbcrq6vvc8JwY1B FaLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=yB8X9R2+ooKakv1gqRRusVDb5msog6XMaORS10eiMiY=; b=ZCMFfZF7dCA2a76/TmI/lV+OEYXk/5yGeTjEyAUXxosNrWB1CJbvlyww7k80zyzqXa ixUxlTreS09eVW5onLR5UYSBLjyqDCNwTKnJ4u4h76eO6VOvfKH5sg0MtAUcIIJE9M+i XIN6BGUCv89BnN6UUBuumxt0Vqn9fG8Wb8ueDzdxxYR1+j3LljlT0Niwmx210GCVWKi7 fVLjw3NFzwCZlk4iEbv7VUOcufMS3hakfLZo8kyZNBi4WDnKWvVYGUEgHpBQb9/XKa0K FludMm1NLyh6pxsAa6OZbhk90ZXgRpvaB2z4gUy1Lu+teDPqLTKVYK4W4nVBOznMeAxk O1Ng== X-Gm-Message-State: AHPjjUjMH5Qdh68NMJFzzkYvudg/C5W7qbUXCx9+QMOaPyGzJlgi+DV0 rna3nvzp6HBHPK9Jb2o0zU9MMIMT+DZLkDnUag== X-Google-Smtp-Source: AOwi7QBOMHGc0Xn+jeIkgLxkDbliJEbXeadTidxg/UVJfZ0CzRyICyHn5jD7OGMWCD0BYKAYTwxDWxkIj/1uL7AC3PA= X-Received: by 10.55.102.13 with SMTP id a13mr5596610qkc.320.1506581629443; Wed, 27 Sep 2017 23:53:49 -0700 (PDT) MIME-Version: 1.0 Sender: sepherosa@gmail.com Received: by 10.140.21.20 with HTTP; Wed, 27 Sep 2017 23:53:48 -0700 (PDT) In-Reply-To: <201709280608.v8S68Lku052325@slippy.cwsent.com> References: <201709270544.v8R5io50067311@repo.freebsd.org> <201709280608.v8S68Lku052325@slippy.cwsent.com> From: Sepherosa Ziehau Date: Thu, 28 Sep 2017 14:53:48 +0800 X-Google-Sender-Auth: tiBNZ4Uup68fz8JgZTE_sSr8wd8 Message-ID: Subject: Re: svn commit: r324049 - head/sys/dev/hyperv/netvsc To: Cy Schubert Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 06:53:51 -0000 Thanks, I am doing a test building. I am planning to drop the Hyper-V on i386, which is never officially supported. On Thu, Sep 28, 2017 at 2:08 PM, Cy Schubert wrote: > In message <201709270544.v8R5io50067311@repo.freebsd.org>, Sepherosa Ziehau > wri > tes: >> Author: sephe >> Date: Wed Sep 27 05:44:50 2017 >> New Revision: 324049 >> URL: https://svnweb.freebsd.org/changeset/base/324049 >> >> Log: >> hyperv/hn: Fix UDP checksum offload issue in Azure. >> >> UDP checksum offload does not work in Azure if following conditions are >> met: >> - sizeof(IP hdr + UDP hdr + payload) > 1420. >> - IP_DF is not set in IP hdr >> >> Use software checksum for UDP datagrams falling into this category. >> >> Add two tunables to disable UDP/IPv4 and UDP/IPv6 checksum offload, in >> case something unexpected happened. >> >> MFC after: 1 week >> Sponsored by: Microsoft >> Differential Revision: https://reviews.freebsd.org/D12429 >> >> Modified: >> head/sys/dev/hyperv/netvsc/if_hn.c >> >> Modified: head/sys/dev/hyperv/netvsc/if_hn.c >> ============================================================================= >> = >> --- head/sys/dev/hyperv/netvsc/if_hn.c Wed Sep 27 04:42:40 2017 >> (r324048) >> +++ head/sys/dev/hyperv/netvsc/if_hn.c Wed Sep 27 05:44:50 2017 >> (r324049) >> @@ -62,6 +62,7 @@ __FBSDID("$FreeBSD$"); >> >> #include >> #include >> +#include > > Shouldn't this go after the #include ? > > Found in tinderbox: > > i386 GENERIC-NODEBUG kernel failed, check _.i386.GENERIC-NODEBUG for details > > In _.i386.GENERIC-NODEBUG: > > In file included from /home/cy/current/sys/dev/hyperv/netvsc/if_hn.c:65: > In file included from /home/cy/current/sys/sys/counter.h:35: > ./machine/counter.h:172:3: error: implicit declaration of function > 'critical_ent > er' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > critical_enter(); > ^ > WARNING: ctfconvert: enum pmc_event has too many values: 2629 > 1023 > ./machine/counter.h:172:3: error: this function declaration is not a > prototype [ > -Werror,-Wstrict-prototypes] > ./machine/counter.h:174:3: error: implicit declaration of function > 'critical_exi > t' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > critical_exit(); > > >> #include >> #include >> #include > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > > -- Tomorrow Will Never Die