From owner-svn-src-all@freebsd.org Mon Jan 22 23:20:44 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAC82EB6AAC; Mon, 22 Jan 2018 23:20:44 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 50DD3743DB; Mon, 22 Jan 2018 23:20:43 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.55.3]) by phk.freebsd.dk (Postfix) with ESMTP id F3A3A27342; Mon, 22 Jan 2018 23:20:41 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w0MNKe9C090453 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 22 Jan 2018 23:20:41 GMT (envelope-from phk@critter.freebsd.dk) Received: (from phk@localhost) by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w0MNKeAV090452; Mon, 22 Jan 2018 23:20:40 GMT (envelope-from phk) To: Warner Losh cc: Ravi Pokala , John Baldwin , Emmanuel Vadot , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules In-reply-to: From: "Poul-Henning Kamp" References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <88258.1516630050@critter.freebsd.dk> <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> <52374125.OgxafgljNu@ralph.baldwin.cx> <89102.1516649067@critter.freebsd.dk> <607B50C2-883C-4CAB-8860-483EC4E9A668@mac.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <90450.1516663240.1@critter.freebsd.dk> Content-Transfer-Encoding: quoted-printable Date: Mon, 22 Jan 2018 23:20:40 +0000 Message-ID: <90451.1516663240@critter.freebsd.dk> X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 23:20:44 -0000 -------- In message , Warner Losh writes: >I think even bootverbose it's insane. Or I don't understand what the real >ask is. What I think would be a good idea, is when a driver is kldloaded the user will be told if there were hardware present which it could drive (ie: probe() matches), but for some reason and somehow, it as marked as unavailable/conflicting/disabled, so attach() didn't. Today you load the device driver and if the hardware is "status=3Ddisabled= " in the FDT, nothing happens, and you get no information about why nothing happened, leaving the user to guess... I've seen people resort to kldload /boot/kernel/*.ko in an attempt to find out if were using the right device driver. I suspect moving the boilerplate if (!ofw_bus_status_okay(dev)) return (ENXIO); To the attach() function would do it, but we could avoid that boilerplate in all the drivers, if it was done one level up with a consistent device_printf() and not calling attach() at all. What I don't know is how noisy that would be in practice ? -- = Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe = Never attribute to malice what can adequately be explained by incompetence= .