Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 15 Nov 2016 17:53:13 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 214542] sysctl_ifmalisti: missing IF_ADDR_RUNLOCK if rtsock_msg_buffer returns error
Message-ID:  <bug-214542-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214542

            Bug ID: 214542
           Summary: sysctl_ifmalisti: missing IF_ADDR_RUNLOCK if
                    rtsock_msg_buffer returns error
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: tony.cai1982@gmail.com

diff --git a/sys/net/rtsock.c b/sys/net/rtsock.c
index ca89002..47777c3 100644
--- a/sys/net/rtsock.c
+++ b/sys/net/rtsock.c
@@ -1798,8 +1798,10 @@ sysctl_ifmalist(int af, struct walkarg *w)
                            (ifma->ifma_addr->sa_family !=3D AF_LINK) ?
                            ifma->ifma_lladdr : NULL;
                        error =3D rtsock_msg_buffer(RTM_NEWMADDR, &info, w,
&len);
-                       if (error !=3D 0)
+                       if (error !=3D 0) {
+                               IF_ADDR_RUNLOCK(ifp);
                                goto done;
+                       }
                        if (w->w_req && w->w_tmem) {
                                struct ifma_msghdr *ifmam;

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-214542-8>