From owner-cvs-all@FreeBSD.ORG  Tue Jan 18 08:35:09 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0E31216A4D1
	for <cvs-all@FreeBSD.org>; Tue, 18 Jan 2005 08:35:09 +0000 (GMT)
Received: from relay.pair.com (relay00.pair.com [209.68.1.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id DEB4443D58
	for <cvs-all@FreeBSD.org>; Tue, 18 Jan 2005 08:35:07 +0000 (GMT)
	(envelope-from silby@silby.com)
Received: (qmail 12422 invoked from network); 18 Jan 2005 08:35:07 -0000
Received: from unknown (HELO localhost) (unknown)
  by unknown with SMTP; 18 Jan 2005 08:35:07 -0000
X-pair-Authenticated: 209.68.2.70
Date: Tue, 18 Jan 2005 02:35:05 -0600 (CST)
From: Mike Silbersack <silby@silby.com>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200501172034.43213.jhb@FreeBSD.org>
Message-ID: <20050118023301.C2462@odysseus.silby.com>
References: <200501170756.j0H7uSU9031593@repoman.freebsd.org>
 <200501172034.43213.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
cc: cvs-src@FreeBSD.org
cc: Mike Silbersack <silby@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sys_pipe.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2005 08:35:09 -0000


On Mon, 17 Jan 2005, John Baldwin wrote:

> On Monday 17 January 2005 02:56 am, Mike Silbersack wrote:
>>   Rearrange the kninit calls for both directions of a pipe so that
>>   they both happen before pipe backing allocation occurs.  Previously,
>>   a pipe memory shortage would cause a panic due to a KNOTE call
>>   on an uninitialized si_note.
>>
>>   Reported by:    Peter Holm
>>   MFC after:      1 week
>
> Good catch!
>
> -- 
> John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/

I hope you mean good catch on Peter's part, not mine.  To create the 
panic, all I had to to was create a simple program which calls pipe 
repeatedly; I should have written / committed that program back when I was 
working on pipes last...

I'm going to commit my simple test program when I get a chance, and see if 
I can write modified versions to test the other allocation failure cases 
as well.

Mike "Silby" Silbersack