From owner-freebsd-current Mon Oct 16 1:45: 1 2000 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 23B3637B66D for ; Mon, 16 Oct 2000 01:44:57 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id TAA17845; Mon, 16 Oct 2000 19:44:38 +1100 Date: Mon, 16 Oct 2000 19:44:33 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Brian Somers Cc: kargl@apl.washington.edu, freebsd-current@FreeBSD.ORG Subject: Re: more endian.h breakage; patch included. In-Reply-To: <200010160739.e9G7dNY21088@hak.lan.Awfulhak.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 16 Oct 2000, Brian Somers wrote: > > On Sun, 15 Oct 2000, Steven G. Kargl wrote: > > > > > There is another patch needed in libdialog. > > > > No patches are needed in applications; endian.h should be unbroken. > > In what way ? endian.h shouldn't depend on or include and its associated namespace pollution. It never did before. > ntohl() & ntonl() were previously wrong to return u_long. Not wrong. They have always been documented to return u_long. > They now return uint32_t (which requires sys/types.h). In NetBSD and in FreeBSD for all arches except i386's they return in_addr_t which happens to be u_int32_t. > They *could* be changed to return u_int32_t, but this doesn't seem to > be the best way forward. I agree that it's not the best way forward, but u_int32_t is traditional namespace pollution in , so using it is safer than using uint32_t. > They *could* be changed to return unsigned, but I think this is worse > than u_int32_t. It is no different for an arch where unsigned is u_int32_t (both conflict with the man page :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message