From owner-cvs-all Tue Jan 12 12:41:02 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA08276 for cvs-all-outgoing; Tue, 12 Jan 1999 12:41:02 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from enya.clari.net.au (enya.clari.net.au [203.8.14.116]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA08244; Tue, 12 Jan 1999 12:40:47 -0800 (PST) (envelope-from danny@enya.clari.net.au) Received: from localhost (danny@localhost) by enya.clari.net.au (8.8.8/8.8.7) with SMTP id HAA15988; Wed, 13 Jan 1999 07:36:22 +1100 (EST) (envelope-from danny@enya.clari.net.au) Date: Wed, 13 Jan 1999 07:36:22 +1100 (EST) From: "Daniel O'Callaghan" To: Guido van Rooij cc: "Daniel O'Callaghan" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/xntpd/parse/util dcfd.c testdcf.c src/usr.sbin/xntpd/xntpd refclock_acts.c refclock_heath.c In-Reply-To: <19990112211918.B24858@gvr.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tue, 12 Jan 1999, Guido van Rooij wrote: > > Fix leap year calculations, including 2000. The code was broken for all > > years! > > Reviewed by: , > > Has this been reported back to the xntpd authors? > > It really surprises me that xntpd has such a problem. Suprised me, too. But it seems that the various clock interpretation files were done by contributors, and some contributors did not understand leap year calculations very well. This is why I check my replacement code for dy_size() several times logically and empirically, and got others to do the same before I committed it. I contacted Harlan Stenn of UDel about this, and he was not interested in xntpd, only ntp-4. The same errors are in ntp-4, and I will be submitting a patch to Dave Mills later today. I'll also update en/y2kbug.html Danny To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message