From owner-svn-src-user@FreeBSD.ORG Sun May 15 23:32:32 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D2FC1065672; Sun, 15 May 2011 23:32:32 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 659D48FC08; Sun, 15 May 2011 23:32:30 +0000 (UTC) Received: by wyf23 with SMTP id 23so4066875wyf.13 for ; Sun, 15 May 2011 16:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZWMdPwxy0eAwzaGCEH0q5F1dBIKhtj/TIgUxmyz5QQ0=; b=mn2LyaCrTlEFWuHdTCMhztQFLKA2YcjKlLCnHWIFJVNfy8VUuqp682R9SL2gNHn2YY aOZOGIflmMZzGnE3Y2S1ItDss/WHxe9J1V+6gnOFZhyKyoa3gmXPbz47O0GklAu8PQw1 iUSXLOLCuq3HSlj5DmjNhgY4KV7o/L4YkTq6o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=kj4JYo+EUT5+uId2feFyySfTHfqVY9hfeWiiNYCCetk0P95TH526XpjMPT8/wkP6nN 4gN9uxx3CWIEggrr9Bd/h/gQvHz23oU0OJZ+eMciJeVCEZxeyEkPam6vtI32fdIDLiJ/ ARSxNSHcri6z0W2IcV9IojSyPPiXe1Q9YZrCA= MIME-Version: 1.0 Received: by 10.216.79.10 with SMTP id h10mr283869wee.20.1305502350097; Sun, 15 May 2011 16:32:30 -0700 (PDT) Received: by 10.216.153.104 with HTTP; Sun, 15 May 2011 16:32:30 -0700 (PDT) In-Reply-To: <4DD00522.2010309@FreeBSD.org> References: <201105151432.p4FEWtTw042031@svn.freebsd.org> <20110515150759.GI111@hoeg.nl> <4DCFFAFF.7020403@FreeBSD.org> <4DD00522.2010309@FreeBSD.org> Date: Sun, 15 May 2011 16:32:30 -0700 Message-ID: From: Matthew Fleming To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Ed Schouten , "src-committers@freebsd.org" , "svn-src-user@freebsd.org" Subject: Re: svn commit: r221962 - in user/avg/xcpu/sys: kern sys X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2011 23:32:32 -0000 On Sunday, May 15, 2011, Andriy Gapon wrote: > on 15/05/2011 19:19 Matthew Fleming said the following: >> On Sunday, May 15, 2011, Andriy Gapon wrote: >>> on 15/05/2011 18:07 Ed Schouten said the following: >>>> Hey Andriy, >>>> >>>> * Andriy Gapon , 20110515 16:32: >>>>> - =A0 =A0if (IS_PANIC_THREAD()) >>>>> + =A0 =A0if (THREAD_PANICED()) >>>> >>>> Shouldn't this be called THREAD_PANICKED(), with the k, instead? >>>> >>> >>> Yes, it should be. =A0Thank you. >> >> Shouldn't it be TD_IS_PANIC[K]ED to match many of the other checks >> like TD_IS_IDLETHREAD? =A0Or perhaps to avoid a spelling change, >> TD_IS_INPANIC? > > I like both of your proposals. =A0Where have you been before? :) > Ok, let's now settle on one best name and I will do another rename, that'= s easy > to do. Maybe I should start reading commits to private branches more often. :-) Cheers, matthew