From owner-p4-projects@FreeBSD.ORG  Mon Feb 25 03:02:08 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 06B9616A406; Mon, 25 Feb 2008 03:02:08 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A91F816A401
	for <perforce@freebsd.org>; Mon, 25 Feb 2008 03:02:07 +0000 (UTC)
	(envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 979D013C4E8
	for <perforce@freebsd.org>; Mon, 25 Feb 2008 03:02:07 +0000 (UTC)
	(envelope-from sam@errno.com)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m1P326f5093649
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <perforce@freebsd.org>; Sun, 24 Feb 2008 19:02:06 -0800 (PST)
	(envelope-from sam@errno.com)
Message-ID: <47C22FAE.3080400@errno.com>
Date: Sun, 24 Feb 2008 19:02:06 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Perforce Change Reviews <perforce@freebsd.org>
References: <200802250254.m1P2stMd015043@repoman.freebsd.org>
In-Reply-To: <200802250254.m1P2stMd015043@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: 
Subject: Re: PERFORCE change 136138 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2008 03:02:08 -0000

Sam Leffler wrote:
> http://perforce.freebsd.org/chv.cgi?CH=136138
>
> Change 136138 by sam@sam_ebb on 2008/02/25 02:54:10
>
> 	o require drivers to allocate the ifnet w/ IFT_IEEE80211
> 	  instead of blindly clobbering if_type in ieee80211_ifattach;
> 	  this is effectively a noop but codifies the fact drivers
> 	  are 802.11-specific
> 	o fix various radiotap bogosity in drivers; in particular
> 	  we no longer need to use bpfattach2 or maintain a private
> 	  sc_drvbpf as if_bpf isn't used by way of attaching as an
> 	  802.11 device (and not calling ether_ifattach)
>
>   
FWIW switching over to use if_bpf is required to make tcpdump work on 
the parent device as otherwise BIOCSETIF fails because it checks for 
if_bpf being NULL and that doesn't happen any more as a side effect of 
calling ether_ifattach.  netbsd is smarter about this; it walks the 
bpf_iflist regardless of if_bpf.

    Sam