From owner-cvs-src@FreeBSD.ORG Thu May 3 17:27:08 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5FF0116A404 for ; Thu, 3 May 2007 17:27:08 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from rm-rstar.sfu.ca (rm-rstar.sfu.ca [142.58.101.21]) by mx1.freebsd.org (Postfix) with ESMTP id 399EF13C46E for ; Thu, 3 May 2007 17:27:08 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from hexahedron.daemonology.net (cperciva@fraser.sfu.ca [142.58.101.25]) by rm-rstar.sfu.ca (8.13.6/8.13.4/SFU-5.0H) with SMTP id l43HR46R007023 for ; Thu, 3 May 2007 10:27:05 -0700 (PDT) X-Spam-Level: Spam-Level Received: (qmail 5146 invoked from network); 3 May 2007 17:20:23 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 3 May 2007 17:20:23 -0000 Message-ID: <463A19D6.6070400@freebsd.org> Date: Thu, 03 May 2007 10:20:22 -0700 From: Colin Percival User-Agent: Thunderbird 1.5.0.9 (X11/20061227) MIME-Version: 1.0 To: Tim Kientzle References: <200705030433.l434XBvW005733@repoman.freebsd.org> <46397035.7000606@freebsd.org> In-Reply-To: <46397035.7000606@freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by antibody.sfu.ca running antivirus scanner Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 17:27:08 -0000 Tim Kientzle wrote: > I wonder if it would be simpler to set non-zero exit only > if this is the first path returned from tree_next() (which > should be the path given on the command line). That > would avoid the headache of having to perform a textual > path comparison. > > A simple flag to indicate if this is the first time > through the loop should suffice, I think. Hmm... I considered this, but I wasn't sure if there were any edge cases where the first path returned by tree_next might not be the path passed to tree_open; so I decided to take the route which I knew would always work. If you're sure that a first-time-through-the-loop flag will work, feel free to change this. :-) Colin Percival