From owner-freebsd-current@FreeBSD.ORG Tue Sep 23 23:20:39 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56E4016A4C0; Tue, 23 Sep 2003 23:20:39 -0700 (PDT) Received: from pcwin002.win.tue.nl (pcwin002.win.tue.nl [131.155.71.72]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29C3B4400D; Tue, 23 Sep 2003 23:20:37 -0700 (PDT) (envelope-from stijn@pcwin002.win.tue.nl) Received: from pcwin002.win.tue.nl (localhost [127.0.0.1]) by pcwin002.win.tue.nl (8.12.10/8.12.10) with ESMTP id h8O6LBLY000364; Wed, 24 Sep 2003 08:21:11 +0200 (CEST) (envelope-from stijn@pcwin002.win.tue.nl) Received: (from stijn@localhost) by pcwin002.win.tue.nl (8.12.10/8.12.10/Submit) id h8O6LBrf000363; Wed, 24 Sep 2003 08:21:11 +0200 (CEST) (envelope-from stijn) Date: Wed, 24 Sep 2003 08:21:11 +0200 From: Stijn Hoop To: Daniel Eischen Message-ID: <20030924062111.GC95116@pcwin002.win.tue.nl> References: <20030924060135.GB95116@pcwin002.win.tue.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vOmOzSkFvhd7u8Ms" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Bright-Idea: Let's abolish HTML mail! cc: ports@freebsd.org cc: jb@freebsd.org cc: current@freebsd.org cc: Kris Kennaway Subject: Re: Initial list of ports that fail due to -pthread X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2003 06:20:39 -0000 --vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 24, 2003 at 02:11:53AM -0400, Daniel Eischen wrote: > On Wed, 24 Sep 2003, Stijn Hoop wrote: > > Just an idea (I hope this hasn't been said before in the mega thread bu= t at > > least I didn't get it this way): > >=20 > > - fix all ports to respect PTHREAD_LIBS _ON THE LINKING STAGE_ (so no > > global search & replace, for it shouldn't be used in compile command > > lines) > This sounds nice, but I don't know that there really is much > difference in changes needed. Well it avoids gcc warnings in case PTHREAD_LIBS =3D=3D '-lkse'. That's abo= ut the only reason I can think of to make the distinction between compiling & linking. > > - keep '-pthread' as a compiler option, which maps to a NOOP for compil= ing > > and '-lpthread' (aka libkse) for linking >=20 > That's already the case; -pthread never did anything on the > compile, only the link. OK, but let's keep it that way then. Isn't the removal of -pthread that sta= rted all this? > > - set PTHREAD_LIBS to the default value of -pthread > > - allow PTHREAD_LIBS to be set to something other, e.g. '-lthr', in > > /etc/make.conf (or the make command line) >=20 > This is already the path that ports is going down :-) Well, great. Let's go and fix some ports then, and everybody will be happy = :) But if this is really the way to go, we probably need some hack to bsd.port= .mk to make PTHREAD_LIBS standard because otherwise every port that needs a threads library needs to have PTHREAD_LIBS hacks. --Stijn --=20 Help Wanted: Telepath. You know where to apply. --vOmOzSkFvhd7u8Ms Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQE/cTfXY3r/tLQmfWcRAsIPAKCYRVpnVzmKirg7JG2QUsmYUjAI3QCgm8l9 /8HelHGL1kVjZgiKC3bN95I= =Ov3S -----END PGP SIGNATURE----- --vOmOzSkFvhd7u8Ms--