From owner-svn-src-all@freebsd.org Tue May 21 00:05:53 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A5181596CE9; Tue, 21 May 2019 00:05:53 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f182.google.com (mail-it1-f182.google.com [209.85.166.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CD5C66A523; Tue, 21 May 2019 00:05:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f182.google.com with SMTP id h11so1889106itf.5; Mon, 20 May 2019 17:05:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=Uh+SsxcJJIUC1fceM1o4cc0dDQpuvRI8PhdBUAyfyCc=; b=jnhh9UK5Q/OVZNV2S6FF5W9V6UK5AYLqyUf90KDy7yDtoyU2269y4MZoMHA0JUSbL1 ddcPdMaijBdbIRbZZbo+ZUZcFE7R5AdYm4CxEatGpro/WctDHR2f4yeISOWNYkUYBGwR 6BUELqgMDfVsRIlYXuaiqG1v3qYyeF6Wd905sQlKPggXnvZc7n6gbMncqzwvWodctGzs vDwPuWOijd1RXQaN5h/LJyY4fZNUS/SSYejraf5FA9Q+AZpLwEMxKfpKex5GgsRr1RZ2 ow6ThNfl+0WEQasOfTmt5QTu42OK165gHhH8MAnvqCtSr/KlmiAEt0PDKxHzdtRFtosg /WUw== X-Gm-Message-State: APjAAAWnjQeExbebQrJB/X51WDZ6guxb8UWSxFFKdDJZH1YmEsMyzH3G tph18Z68mclppsQR5kxJuD1p4Lzm X-Google-Smtp-Source: APXvYqxOAR2OREMIYLXsL+oP2puLtQ44Byn4rWRzTxJEkWN/QMw2/XCV1egBrH56nQWTrqwRAsEGfw== X-Received: by 2002:a02:95aa:: with SMTP id b39mr49464656jai.45.1558396811207; Mon, 20 May 2019 17:00:11 -0700 (PDT) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com. [209.85.166.44]) by smtp.gmail.com with ESMTPSA id r139sm573844ita.22.2019.05.20.17.00.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 17:00:10 -0700 (PDT) Received: by mail-io1-f44.google.com with SMTP id s20so12486087ioj.7; Mon, 20 May 2019 17:00:10 -0700 (PDT) X-Received: by 2002:a05:6602:157:: with SMTP id v23mr5175944iot.80.1558396810738; Mon, 20 May 2019 17:00:10 -0700 (PDT) MIME-Version: 1.0 References: <201905200038.x4K0cNoZ019920@repo.freebsd.org> <20190520192047.GA3524@server.rulingia.com> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 20 May 2019 16:59:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12... To: Peter Jeremy Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CD5C66A523 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2019 00:05:53 -0000 Hi Peter, Can you share what your kernel configuration is? I believe the error is masked in existing tinderbox kernel configurations ( https://ci.freebsd.org/tinderbox/ ) by some remaining header pollution that must be conditional on an option. The files you've pointed out are missing the eventhandler header (and fixing that is trivial), but I'd like to better understand where the leak is so that other misses can be located. Thanks, Conrad On Mon, May 20, 2019 at 12:31 PM Conrad Meyer wrote: > > Hi Peter, > > Thanks for reporting this. I ran a full tinderbox on this change > (many many tinderboxes) and am not sure how I missed this. I have to > run to an appointment now, but will fix these in a couple hours if no > one else beats me to it. The fix is straightforward =E2=80=94 include > . > > Best, > Conrad > > On Mon, May 20, 2019 at 12:21 PM Peter Jeremy wrote: > > > > On 2019-May-20 00:38:23 +0000, Conrad Meyer wrote: > > >Author: cem > > >Date: Mon May 20 00:38:23 2019 > > >New Revision: 347984 > > >URL: https://svnweb.freebsd.org/changeset/base/347984 > > > > > >Log: > > > Extract eventfilter declarations to sys/_eventfilter.h > > ... > > > No functional change (intended). Of course, any out of tree modules= that > > > relied on header pollution for sys/eventhandler.h, sys/lock.h, or > > > sys/mutex.h inclusion need to be fixed. __FreeBSD_version has been = bumped. > > > > This seems to have broken at least netmap and netdump for me: > > /usr/src/sys/dev/netmap/netmap_freebsd.c:191:3: error: implicit declara= tion of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-Wimpli= cit-function-declaration] > > EVENTHANDLER_REGISTER(ifnet_arrival_event, > > ^ > > ... > > /usr/src/sys/netinet/netdump/netdump_client.c:1458:22: error: implicit = declaration of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,= -Wimplicit-function-declaration] > > nd_detach_cookie =3D EVENTHANDLER_REGISTER(ifnet_depart= ure_event, > > ^ > > > > -- > > Peter Jeremy