From owner-freebsd-arch@FreeBSD.ORG Sun Mar 30 23:57:20 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D50437B401 for ; Sun, 30 Mar 2003 23:57:20 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 31E7943F85 for ; Sun, 30 Mar 2003 23:56:58 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h2V7uSAP085158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Mar 2003 10:56:28 +0300 (EEST) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.8/8.12.8/Submit) id h2V7uNqC085135; Mon, 31 Mar 2003 10:56:23 +0300 (EEST) (envelope-from ru) Date: Mon, 31 Mar 2003 10:56:23 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20030331075623.GA82512@sunbay.com> References: <20030329.163343.53040416.imp@bsdimp.com> <20030331042628.GA65700@sunbay.com> <20030331165732.Q17731@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <20030331165732.Q17731@gamplex.bde.org> User-Agent: Mutt/1.5.4i cc: arch@freebsd.org cc: "M. Warner Losh" Subject: Re: depend + all vs dependall X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2003 07:57:22 -0000 --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 31, 2003 at 05:04:42PM +1000, Bruce Evans wrote: > On Mon, 31 Mar 2003, Ruslan Ermilov wrote: >=20 > > On Sat, Mar 29, 2003 at 04:33:43PM -0700, M. Warner Losh wrote: > > ... > > > @@ -67,7 +67,7 @@ > > > > > > > > > .for __target in all all-man checkdpadd clean cleandepend cleandir \ > > > - depend distribute lint maninstall \ > > > + depend dependall distribute lint maninstall \ > > > obj objlink realinstall regress tags > > > ${__target}: _SUBDIR > > > .endfor > > > > If you want to really try dependall, you should implement it > > in bsd.subdir.mk like the distribute target, similar to this: > > > > .if !target(dependall) > > dependall: > > cd ${.CURDIR}; \ > > ${MAKE} depend -DNO_SUBDIR; \ > > ${MAKE} all -DNO_SUBDIR > > .endif >=20 > That won't work, since it gives a double tree traversal for the > subdirs and thus defeats the point of dependall. Any splitting > up of dependall must not be passed down. >=20 > > Also, your test is not honest because original Makefile.inc1 > > did not parallelize the "all" stage of "buildworld", by not > > implementing par-all. Last time I tried par-all, it saved > > me 16% of time from the -j8 buildworld: > > > > 26m8.74s real 26m13.08s user 11m9.70s sys (old) > > 21m48.52s real 26m20.60s user 11m4.95s sys (new) > > > > Attached is the message with the patch. It has some Russian, > > but also includes a patch. Note that par-all only parallelizes > > top-level bsd.subdir.mk makefiles, as we depend on the ordering > > of traversing SUBDIRs in a few places. The plan is to drop > > this assumption in places that don't need this ordering. >=20 > Please benchmark mainly for the usual case of non-SMP :-). >=20 You mean for the non-SMP case but with -j? On a Celeron 800 system with ATA100 disk using -j4 -DNOCLEAN buildworld of RELENG_4 a friend reported the following times: Without patch With patch real 69m43.271s 69m26.722s user 38m22.009s 38m19.384s sys 10m45.273s 10m41.596s Further reports show that on single-CPU systems with large CPU cache the real time win was near what I have reported for 2-CPU box, and it had no effect on small cache single-CPU systems and -j builds. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+h/SnUkv4P6juNwoRAncVAJ9s43OcueEcqlcyZcji1X+ghi6NvACfXw3E ZIQ2HN9MoqBVvWBB8ym4LPI= =749t -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--