From owner-svn-src-all@FreeBSD.ORG  Tue Apr 16 20:01:31 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 4346E377;
 Tue, 16 Apr 2013 20:01:31 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 07D2213C5;
 Tue, 16 Apr 2013 20:01:30 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7::b037:d3c5:d0df:2e6b] (unknown
 [IPv6:2001:7b8:3a7:0:b037:d3c5:d0df:2e6b])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 39C8E5C44;
 Tue, 16 Apr 2013 22:01:28 +0200 (CEST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\))
Subject: Re: svn commit: r249564 - head/sys/geom/label
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <201304161958.r3GJwO2h084815@svn.freebsd.org>
Date: Tue, 16 Apr 2013 22:01:21 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <A3DEE105-8443-4F77-8F35-99AA0E64D044@FreeBSD.org>
References: <201304161958.r3GJwO2h084815@svn.freebsd.org>
To: Ivan Voras <ivoras@FreeBSD.org>
X-Mailer: Apple Mail (2.1503)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2013 20:01:31 -0000

On Apr 16, 2013, at 21:58, Ivan Voras <ivoras@FreeBSD.org> wrote:
> Author: ivoras
> Date: Tue Apr 16 19:58:24 2013
> New Revision: 249564
> URL: http://svnweb.freebsd.org/changeset/base/249564
> 
> Log:
>  Fix the buffer-overflow-fixing fixes.
...
> +		/*
> +		 * We can safely ignore the result of strncpy; the label will
> +		 * simply be truncated, which at most is only annoying.
> +		 */
> +		(void)snprintf(label, size, "%s-%s", cls->name, ident);

s/strncpy/snprintf/ ? :-)