From owner-freebsd-questions@FreeBSD.ORG  Sat Feb 23 20:49:55 2013
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id AE3A9D96;
 Sat, 23 Feb 2013 20:49:55 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id 7AF9C2A2;
 Sat, 23 Feb 2013 20:49:55 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id D46278AF;
 Sat, 23 Feb 2013 21:46:56 +0100 (CET)
Date: Sat, 23 Feb 2013 21:51:03 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Mikolaj Golub <trociny@FreeBSD.org>
Subject: Re: HAST - detect failure and restore avoiding an outage?
Message-ID: <20130223205103.GN1377@garage.freebsd.pl>
References: <E3C8C9A2-712E-4925-995A-0471CCD3515B@balius.com>
 <20130221220042.GA2900@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="jh06fhy6YTawvwPV"
Content-Disposition: inline
In-Reply-To: <20130221220042.GA2900@gmail.com>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Chad M Stewart <cms@balius.com>, freebsd-questions@freebsd.org
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Feb 2013 20:49:55 -0000


--jh06fhy6YTawvwPV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 22, 2013 at 12:00:43AM +0200, Mikolaj Golub wrote:
> It looks currently logs are only way to detect errors from hastd side.
> Here is a patch that adds local i/o error statistics, accessable avia
> hastctl:
>=20
> http://people.freebsd.org/~trociny/hast.stat_error.1.patch
>=20
> hastctl output:
>=20
>   role: secondary
>   provname: test
>   localpath: /dev/md102
>   extentsize: 2097152 (2.0MB)
>   keepdirty: 0
>   remoteaddr: kopusha:7771
>   replication: memsync
>   status: complete
>   dirty: 0 (0B)
>   statistics:
>     reads: 0
>     writes: 366
>     deletes: 0
>     flushes: 0
>     activemap updates: 0
>     local i/o errors: 269
>=20
> Pawel, what do you think about this patch?


I'm fine with the patchi except for missing breaks in switch added to
hastd/primary.c.

I'm also wondering... You count all those errors separately just to
print them as one number. If we do that already let's print them
separately, eg.

	local i/o errors: read(0), write(3), delete(5), flush(9)

BTW. Why not to count activemap update errors as write and flush errors?

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--jh06fhy6YTawvwPV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlEpK7cACgkQForvXbEpPzRiWwCfadfw1ncKUdyvM7J/6ObjAbJO
FYgAoItNIzmXP3U0FRWi0ynG+hSEijKI
=sw5K
-----END PGP SIGNATURE-----

--jh06fhy6YTawvwPV--