From owner-freebsd-bugs@FreeBSD.ORG Fri Sep 2 18:00:34 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF4F716A41F for ; Fri, 2 Sep 2005 18:00:34 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50F3E43D49 for ; Fri, 2 Sep 2005 18:00:34 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j82I0YPT055119 for ; Fri, 2 Sep 2005 18:00:34 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j82I0Y2l055112; Fri, 2 Sep 2005 18:00:34 GMT (envelope-from gnats) Resent-Date: Fri, 2 Sep 2005 18:00:34 GMT Resent-Message-Id: <200509021800.j82I0Y2l055112@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ben Thomas Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C601316A41F for ; Fri, 2 Sep 2005 17:56:02 +0000 (GMT) (envelope-from bthomas@virtualiron.com) Received: from mail.virtualiron.com (mail.virtualiron.com [209.213.88.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4453643D58 for ; Fri, 2 Sep 2005 17:56:02 +0000 (GMT) (envelope-from bthomas@virtualiron.com) Received: from [10.1.2.26] ([10.1.2.26]) by mail.virtualiron.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 2 Sep 2005 13:56:37 -0400 Message-Id: <43189230.7050603@virtualiron.com> Date: Fri, 02 Sep 2005 13:56:00 -0400 From: Ben Thomas To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: kern/85648: [patch] provide more specific default network driver queue mutex name X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2005 18:00:34 -0000 >Number: 85648 >Category: kern >Synopsis: [patch] provide more specific default network driver queue mutex name >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Sep 02 18:00:33 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Ben Thomas >Release: FreeBSD 5.4-RELEASE i386 >Organization: Virtual Iron Software >Environment: System: FreeBSD bthomas4.katana-technology.com 5.4-RELEASE FreeBSD 5.4-RELEASE #10: Sun Aug 28 13:48:00 EDT 2005 ben@bthomas4.katana-technology.com:/usr/obj/usr/home/ben/BSD/RELENG_5_4_0_RELEASE/src/sys/BEN i386 >Description: This change modifies the default name given to a network driver queue mutex. The new name contains the device name, which makes for easier debugging and tracking. While tracking down mutexes and debugging, it made work a little easier to have more specific names on mutexes. This patch is against the 5_4_0_RELEASE code >How-To-Repeat: >Fix: --- if.c-DIFF begins here --- --- /usr/src.original/sys/net/if.c Thu Apr 14 21:52:03 2005 +++ /usr/src/sys/net/if.c Fri Aug 5 17:31:35 2005 @@ -291,6 +291,7 @@ { struct ifnet *ifp; int s; + char name[IFNAMSIZ + sizeof(" ifq_mtx") + 1]; s = splimp(); IFNET_RLOCK(); /* could sleep on rare error; mostly okay XXX */ @@ -300,9 +301,10 @@ ifp->if_snd.ifq_maxlen = ifqmaxlen; } if (!mtx_initialized(&ifp->if_snd.ifq_mtx)) { + snprintf(name, sizeof(name), "%s ifq_mtx", ifp->if_xname); if_printf(ifp, - "XXX: driver didn't initialize queue mtx\n"); - mtx_init(&ifp->if_snd.ifq_mtx, "unknown", + "XXX: Initializing driver queue mtx to '%s'\n", name); + mtx_init(&ifp->if_snd.ifq_mtx, name, MTX_NETWORK_LOCK, MTX_DEF); } } --- if.c-DIFF ends here --- >Release-Note: >Audit-Trail: >Unformatted: