Date: Sun, 13 Mar 2016 15:32:20 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: <src-committers@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <svn-src-head@FreeBSD.org>, <sjg@juniper.net> Subject: Re: svn commit: r296637 - in head: contrib/bmake contrib/bmake/mk contrib/bmake/unit-tests share/mk usr.bin/bmake Message-ID: <14946.1457908340@kaos.jnpr.net> In-Reply-To: <56E5C2EB.1070206@FreeBSD.org> References: <201603110135.u2B1Zd8a001604@repo.freebsd.org> <56E5C2EB.1070206@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bryan Drewery <bdrewery@FreeBSD.org> wrote:
> > # MACHINE specific depend files are supported, but *not* default.
> > # If any already exist, we should follow suit.
> > _aml = ${ALL_MACHINE_LIST:Uarm amd64 i386 powerpc:N${MACHINE}} ${MACHINE}
> > -# MACHINE must be the last entry in _aml ;-)
> > +# make sure we restore MACHINE
> > +_m := ${MACHINE}
> > _e := ${_aml:@MACHINE@${.MAKE.DEPENDFILE_PREFERENCE:@m@${exists($m):?$m:}@}@}
> > +MACHINE := ${_m}
> > .if !empty(_e)
> > .MAKE.DEPENDFILE ?= ${.MAKE.DEPENDFILE_PREFERENCE:M*${MACHINE}:[1]}
> > .endif
>
>
> What changed in bmake to require this? Now in older checkouts I don't
deleting the :@ loop iterator variable.
> get MACHINE defined with DIRDEPS_BUILD without this change. That's not
> ideal since it breaks older builds.
Yes, I should mfc the above change? it is harmess with older bmake's.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14946.1457908340>