Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Sep 2020 17:08:52 +0200
From:      Thomas Zander <riggs@freebsd.org>
To:        Jan Beich <jbeich@freebsd.org>
Cc:        "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r550187 - head/multimedia/libass
Message-ID:  <CAFU734wiay9WG_K3yxUBndK4yNb4=RLi7bGuZKcmgNeHzKnBrg@mail.gmail.com>
In-Reply-To: <4knk-38mi-wny@FreeBSD.org>
References:  <202009261416.08QEGOFc051658@repo.freebsd.org> <4knk-38mi-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 26 Sep 2020 at 16:39, Jan Beich <jbeich@freebsd.org> wrote:
>
> Thomas Zander <riggs@FreeBSD.org> writes:
>
> > +MASTER_SITES=        https://github.com/libass/libass/releases/download/${DISTVERSION}/
>
> Maybe replace libass with ${PORTNAME}, so MASTER_SITES is more generic.

That's true. Thx!

> > -USE_GITHUB=  yes
> > -
> > -USES=                autoreconf iconv libtool pathfix pkgconfig
> > +USES=                autoreconf iconv libtool pathfix pkgconfig tar:xz
>
> Why did you keep USES=autoreconf given pre-generated configure script in the new distfile?

I hit compilation issues with the pre-generated configure script during testing.
Since we had no problem with the non-release-tarball generating
configure, I opted to continue using autoreconf for now.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU734wiay9WG_K3yxUBndK4yNb4=RLi7bGuZKcmgNeHzKnBrg>