From owner-svn-src-head@freebsd.org  Tue Sep 22 14:24:18 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52911A06DD8
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Tue, 22 Sep 2015 14:24:18 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org
 [54.200.247.200])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 32CB514F1
 for <svn-src-head@freebsd.org>; Tue, 22 Sep 2015 14:24:17 +0000 (UTC)
 (envelope-from ian@freebsd.org)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Tue, 22 Sep 2015 14:23:41 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id t8MEN7o0001169;
 Tue, 22 Sep 2015 08:23:07 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1442931787.1224.205.camel@freebsd.org>
Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes
From: Ian Lepore <ian@freebsd.org>
To: Dimitry Andric <dim@FreeBSD.org>
Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Tue, 22 Sep 2015 08:23:07 -0600
In-Reply-To: <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org>
References: <201509220935.t8M9ZZfD051027@repo.freebsd.org>
 <20150922094301.GW3158@zxy.spb.ru>
 <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 14:24:18 -0000

On Tue, 2015-09-22 at 11:53 +0200, Dimitry Andric wrote:
> On 22 Sep 2015, at 11:43, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote:
> > 
> > On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote:
> ...
> >> -			  imm |= (-1 << 7);
> >> +			  imm |= -(1 << 7);
> > 
> > May be (~0 << 7) is more simple to understund?
> 
> This will give the same warning.  ~0 will implicitly convert to -1.
> 
> (It would be better to convert all these masks to unsigned, where such
> shifting is always defined, but that gives a lot more churn.)
> 
> -Dimitry
> 

How is (-1U << 7) more churn?

-- Ian