Date: Sun, 27 Mar 2016 18:26:52 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r296637 - in head: contrib/bmake contrib/bmake/mk contrib/bmake/unit-tests share/mk usr.bin/bmake Message-ID: <20160327162652.GB87149@stack.nl> In-Reply-To: <15542.1457911750@kaos.jnpr.net> References: <201603110135.u2B1Zd8a001604@repo.freebsd.org> <56E5C2EB.1070206@FreeBSD.org> <14946.1457908340@kaos.jnpr.net> <56E5F36E.2020205@FreeBSD.org> <15542.1457911750@kaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 13, 2016 at 04:29:10PM -0700, Simon J. Gerraty wrote: > Bryan Drewery <bdrewery@FreeBSD.org> wrote: > > This code is only in head. My problem is now bmake can only build > > commits after this one which breaks bisecting and older project branches > > which haven't or can't merge in head yet. > > Is the :@ iterator variable deletion change in bmake change necessary? > In the sense of good hygiene, yes. > Obviously make will work without it since its been that way for 15 > years, but this AFAIK is the only makefile affected. I think the ability to bisect without weird local hacks is valuable, although I rarely do this in a FreeBSD context. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160327162652.GB87149>