From owner-cvs-src-old@FreeBSD.ORG Sat Feb 28 11:25:15 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F4551065686 for ; Sat, 28 Feb 2009 11:25:15 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8C6DE8FC08 for ; Sat, 28 Feb 2009 11:25:15 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n1SBPFan070475 for ; Sat, 28 Feb 2009 11:25:15 GMT (envelope-from mav@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n1SBPFl8070474 for cvs-src-old@freebsd.org; Sat, 28 Feb 2009 11:25:15 GMT (envelope-from mav@repoman.freebsd.org) Message-Id: <200902281125.n1SBPFl8070474@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to mav@repoman.freebsd.org using -f From: Alexander Motin Date: Sat, 28 Feb 2009 11:25:05 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-disk.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2009 11:25:16 -0000 mav 2009-02-28 11:25:05 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-disk.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Log: SVN rev 189166 on 2009-02-28 11:25:05Z by mav Rework device probing by moving ata_getparam() call from ata_identify() to drivers' probe routines. It allows not to sleep and so not drop Giant inside ata_identify() critical section and so avoid crash if it reentered on request timeout. Reentering of probe call checked inside of it. Give device own knowledge about it's type (ata/atapi/atapicam). It is not a good idea to ask channel status for device type inside ata_getparam(). Add softc memory deallocation on device destruction. Revision Changes Path 1.302 +44 -39 src/sys/dev/ata/ata-all.c 1.141 +8 -0 src/sys/dev/ata/ata-all.h 1.214 +12 -0 src/sys/dev/ata/ata-disk.c 1.60 +8 -12 src/sys/dev/ata/atapi-cam.c 1.204 +12 -0 src/sys/dev/ata/atapi-cd.c 1.118 +13 -0 src/sys/dev/ata/atapi-fd.c 1.112 +12 -0 src/sys/dev/ata/atapi-tape.c