From owner-p4-projects@FreeBSD.ORG  Mon Feb 22 08:49:34 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 562DB1065694; Mon, 22 Feb 2010 08:49:34 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0F4291065676
	for <perforce@FreeBSD.org>; Mon, 22 Feb 2010 08:49:34 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id F04EA8FC27
	for <perforce@FreeBSD.org>; Mon, 22 Feb 2010 08:49:33 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o1M8nX7U050706
	for <perforce@FreeBSD.org>; Mon, 22 Feb 2010 08:49:33 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o1M8nXGb050704
	for perforce@freebsd.org; Mon, 22 Feb 2010 08:49:33 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Mon, 22 Feb 2010 08:49:33 GMT
Message-Id: <201002220849.o1M8nXGb050704@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 174962 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Feb 2010 08:49:34 -0000

http://p4web.freebsd.org/chv.cgi?CH=174962

Change 174962 by hselasky@hselasky_laptop001 on 2010/02/22 08:48:42

	USB serial:
	
		- bugfix for uvisor driver
	
		- it appears that some UVISOR devices do not
		  handle when the clear stall command is issued at
		  the beginning of the initial IN/OUT data transfers.
		  Reason unknown, probably firmware fault. After patch
		  stall is only cleared on data transfer errors.
	
	PR:		usb/144199

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/serial/uvisor.c#17 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/serial/uvisor.c#17 (text+ko) ====

@@ -345,11 +345,6 @@
 		DPRINTF("could not allocate all pipes\n");
 		goto detach;
 	}
-	/* clear stall at first run */
-	mtx_lock(&sc->sc_mtx);
-	usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_WR]);
-	usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_RD]);
-	mtx_unlock(&sc->sc_mtx);
 
 	error = ucom_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uvisor_callback, &sc->sc_mtx);