From owner-cvs-all@FreeBSD.ORG  Mon Mar  8 19:21:58 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D8E3316A4D0; Mon,  8 Mar 2004 19:21:58 -0800 (PST)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au
	[210.50.30.52])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 22B5C43D41; Mon,  8 Mar 2004 19:21:58 -0800 (PST)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from robbins.dropbear.id.au (210.50.204.98) by
	smtp01.syd.iprimus.net.au (7.0.024)
	id 402BA9270081FB85; Tue, 9 Mar 2004 14:21:55 +1100
Received: by robbins.dropbear.id.au (Postfix, from userid 1000)
	id 404244165; Tue,  9 Mar 2004 14:22:48 +1100 (EST)
Date: Tue, 9 Mar 2004 14:22:48 +1100
From: Tim Robbins <tjr@freebsd.org>
To: John Birrell <jb@FreeBSD.org>
Message-ID: <20040309032248.GA88649@cat.robbins.dropbear.id.au>
References: <200403090245.i292j0a6035728@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200403090245.i292j0a6035728@repoman.freebsd.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/stdio _flock_stub.c local.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Mar 2004 03:21:59 -0000

On Mon, Mar 08, 2004 at 06:44:59PM -0800, John Birrell wrote:

> jb          2004/03/08 18:44:59 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libc/stdio       _flock_stub.c local.h 
>   Log:
>   On 4.X it was possible for an application to initialise a local FILE
>   structure and call stdio functions. In 5.X this was broken when FILE
>   locking was introduced into libc.
>   
>   This change makes most (relevant) stdio functions work again when the
>   _extra file in FILE isn't initialised (and can't be without a libc
>   function to do it since the __sFILEX structure is private to libc).

Is this a useful behaviour to support? ORIENT needs to be kept as
simple as possible since it is invoked for every single stdio call.
The extra conditional may make a difference for getc() and putc()
in the single-threaded case.


Tim