From owner-freebsd-wireless@FreeBSD.ORG  Fri Aug  2 21:23:42 2013
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 2012C34E
 for <freebsd-wireless@freebsd.org>; Fri,  2 Aug 2013 21:23:42 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com
 [IPv6:2a00:1450:400c:c00::22c])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id AB56A2B84
 for <freebsd-wireless@freebsd.org>; Fri,  2 Aug 2013 21:23:41 +0000 (UTC)
Received: by mail-wg0-f44.google.com with SMTP id l18so898774wgh.11
 for <freebsd-wireless@freebsd.org>; Fri, 02 Aug 2013 14:23:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
 :content-transfer-encoding;
 bh=1c9J9sbV4LsbdzER3jtfLLgrFo5wFvLN0QVJ09bWB1s=;
 b=amslRsCTUd32zvSwk2CBIfI9UV72+5XK5F1g8GOW4Om7VHjva1XklNorgIVw3fn8zR
 IjuBvewhPe3b1PGms3nHV9Ggz+Oxh/G15vFbEvYzDQWIJlmyK69fy3nYNNr3Fokow3hL
 9Pvcb0l3uIgCS6cBjhKNR+bFcG+5EHXqSEPpHTWF8u00DX9MlQoQSn8BeXQI8GLstDyD
 IzW111s+1hEXaqMPZFsiT3zYEiAmCs8ar9G+6U6LwUk/dYuK4raBi6b53UxDf3tQkyol
 +cOHwOTYd3Rz9D2Pg8SnZGMAm4WiYtgFkPrcjykqCxi7mT6eRk4S+zuNAqVCB/uoBdi+
 dYkg==
MIME-Version: 1.0
X-Received: by 10.180.20.116 with SMTP id m20mr105059wie.46.1375478619798;
 Fri, 02 Aug 2013 14:23:39 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.217.94.132 with HTTP; Fri, 2 Aug 2013 14:23:39 -0700 (PDT)
In-Reply-To: <00a601ce8c8a$f21570f0$d64052d0$@info>
References: <007601ce8c73$2b508cf0$81f1a6d0$@info>
 <CAJ-Vmok8s+ZmJonko8m7Vk7h8Bv1=eHfPmCWD2Oq6ybWwJkzxg@mail.gmail.com>
 <alpine.BSF.2.00.1307291206050.45456@wonkity.com>
 <00a601ce8c8a$f21570f0$d64052d0$@info>
Date: Fri, 2 Aug 2013 14:23:39 -0700
X-Google-Sender-Auth: iDCeEN6Ue6vBMdzsVoog7wYOduw
Message-ID: <CAJ-Vmok=bFVRVrnkdAA+csXPKV6iE_jruMKs45KX1WB--eV=sg@mail.gmail.com>
Subject: Re: [iwn] Review split 3
From: Adrian Chadd <adrian@freebsd.org>
To: Cedric GROSS <cg@cgross.info>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-wireless@freebsd.org
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Aug 2013 21:23:42 -0000

Committed ,thanks!



-adrian

On 29 July 2013 11:39, Cedric GROSS <cg@cgross.info> wrote:
>
>
>> De : Warren Block [mailto:wblock@wonkity.com]
>> Envoy=E9 : lundi 29 juillet 2013 20:11
>> =C0 : Adrian Chadd
>> Cc : Cedric GROSS; freebsd-wireless@freebsd.org
>>
>> On Mon, 29 Jul 2013, Adrian Chadd wrote:
>>
>> > Hi!
>> >
>> > Cool! ok, the style niggles.
>> >
>> > * Your #define IWN_blah needs a TAB between #define and the IWN_blah
>> > value. Right now you have spaces.
>
> Ok, I tough you need spaces between #define and values...
>
> standard single-include stuff : Done
> $FreeBSD$ : Moved
>
> Each file is different. Really hard to find something common. Man 9 style=
 is
> quite useful but enough precise for tab and space usage I think.
>
>>
>> There is whitespace at the end of some of the comment lines also.
>>
>> textproc/igor will find problems like that:
>>
>>    igor -R filename | less -RS
>
> Thanks for that Warren !