From owner-svn-src-all@freebsd.org Tue Apr 9 19:44:34 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB133156B641; Tue, 9 Apr 2019 19:44:34 +0000 (UTC) (envelope-from chris@rees.space) Received: from mail56c50.megamailservers.eu (mail168c50.megamailservers.eu [91.136.10.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC39176736; Tue, 9 Apr 2019 19:44:32 +0000 (UTC) (envelope-from chris@rees.space) X-Authenticated-User: bayofrum@uwclub.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1554839064; bh=lL2SyZ4bKP4rDwFGUY+fNQjVuMtUDqmCCBGEmCMCMyI=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=NAwbUG6MxcTBwR+r8kvxTfSD5V8jReGTv2HXE8hx/81FcGWLVE5q9qNSufpSUsP4x i8Uquhl1rNC0f5Kld9ji8EHnudNQ3MFAvNq058DXugrVegocczcbsuMPkWT4rTpX+l w1/nB5yH8SI63px9/rYAdFB7VfDiTqQ/8Qb1kxAw= Feedback-ID: chris@rees.spac Received: from pegasus.bayofrum.net (81-178-238-70.dsl.pipex.com [81.178.238.70]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x39JiMsh017486; Tue, 9 Apr 2019 19:44:24 +0000 Received: from [192.168.1.121] (POSEIDON.bayofrum.net [192.168.1.121]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 5C79F17BD; Tue, 9 Apr 2019 20:44:20 +0100 (BST) Subject: Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5 To: rgrimes@freebsd.org, Chris Rees CC: "O. Hartmann" , Chris Rees , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904091833.x39IX4pW061476@gndrsh.dnsmgr.net> From: Chris Rees Message-ID: <11ce03d7-8ebc-2b08-baa8-3fb31a29b3b2@rees.space> Date: Tue, 9 Apr 2019 20:43:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <201904091833.x39IX4pW061476@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 5C79F17BD.A289E X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: chris@rees.space X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B020F.5CACF618.0060, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=G6gy7es5 c=1 sm=1 tr=0 a=i0HMBnJGy7D3/NFKO8d8XA==:117 a=i0HMBnJGy7D3/NFKO8d8XA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=oexKYjalfGEA:10 a=Y8a21bOVD5kA:10 a=ZZnuYtJkoWoA:10 a=iaTFZB6CAAAA:8 a=6I5d2MoRAAAA:8 a=FFKAGiKUUngNVcG6qM8A:9 a=QEXdDO2ut3YA:10 a=HOOHyrUpFT4A:10 a=QWXrQ9iV8q7LKaLQ9lfw:22 a=IjZwj45LgO3ly-622nXo:22 X-Rspamd-Queue-Id: CC39176736 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_SHORT(-0.96)[-0.962,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 19:44:35 -0000 Hi Rod, On 09/04/2019 19:33, Rodney W. Grimes wrote: >> Hey, >> >> On 9 April 2019 14:13:54 BST, "O. Hartmann" wrote: >>> On Sun, 7 Apr 2019 18:31:45 +0000 (UTC) >>> Chris Rees wrote: >>> >>>> Author: crees (doc,ports committer) >>>> Date: Sun Apr 7 18:31:45 2019 >>>> New Revision: 346017 >>>> URL: https://svnweb.freebsd.org/changeset/base/346017 >>>> >>>> Log: >>>> Remove now unnecessary kldstat check before attempting to load >>> modules. >>>> Since r233109, kldload has the -n option, which silently ignores >>> options >>>> that are already loaded. >>>> >>>> >>> https://lists.freebsd.org/pipermail/freebsd-rc/2018-December/003899.html >>>> Note that this script no longer reports if the module is already >>> loaded, >>>> but it could be argued this wasn't particularly useful information. >>>> >>>> PR: docs/234248 >>>> Reviewed by: bcr (docs), kib, rgrimes (visual) >>>> Approved by: jilles >>>> Differential Revision: https://reviews.freebsd.org/D18670 >>>> >>>> Modified: >>>> head/libexec/rc/rc.d/abi >>>> head/libexec/rc/rc.d/bthidd >>>> head/libexec/rc/rc.d/cfumass >>>> head/libexec/rc/rc.d/kld >>>> head/libexec/rc/rc.d/mdconfig >>>> head/libexec/rc/rc.d/mdconfig2 >>>> head/libexec/rc/rc.d/mountcritremote >>>> head/libexec/rc/rc.d/syscons >>>> head/libexec/rc/rc.subr >>>> head/share/man/man5/rc.conf.5 >>>> >>>> Modified: head/libexec/rc/rc.d/abi >>>> >>> ============================================================================== >> >> {Snip} >> >> >>> It seems this patch breaks ZFS if ZFS is built-in kernel! >>> >>> Having ZFS as kernel built-in leaves the system not mounting ANY(!) ZFS >>> volume >>> at boot time, rendering servers unusable. >>> Mounting ZFS filesystems with "zfs mount -a" bring back the ZFS >>> filesystems as >>> expected. >>> >> Are you sure it's this causing that? Please try reverting it. > I think the trigger issue is: > grep zfs /etc/rc.d/zvol > rcvar="zfs_enable" > required_modules="zfs" > > that module requires may be going south with the > new code when the module is built into the kernel. I wondered that, but I don't think so. [crees@pegasus]~% kldstat -v |head Id Refs Address            Size     Name  1   30 0xffffffff80200000 11df240  kernel (/boot/kernel.PEGASUS/kernel)         Contains modules:                 Id Name                 227 newreno                 215 if_lo                 229 ipsec                 228 mld                 226 igmp                 201 elf32 [crees@pegasus]~% sudo kldload ipsec kldload: can't load ipsec: module already loaded or in kernel [crees@pegasus]~% sudo kldload -n ipsec [crees@pegasus]~% echo $? 0 [crees@pegasus]~% The required_modules code calls load_kld, which uses kldload -n. This always returns true... unless Oliver has removed the zfs module from /boot/kernel perhaps? Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.