From owner-cvs-all Sat Mar 18 11:34:59 2000 Delivered-To: cvs-all@freebsd.org Received: from holly.calldei.com (adsl-208-191-146-189.dsl.hstntx.swbell.net [208.191.146.189]) by hub.freebsd.org (Postfix) with ESMTP id D94F137BB65; Sat, 18 Mar 2000 11:34:49 -0800 (PST) (envelope-from chris@holly.calldei.com) Received: (from chris@localhost) by holly.calldei.com (8.9.3/8.9.3) id NAA81968; Sat, 18 Mar 2000 13:34:04 -0600 (CST) (envelope-from chris) Date: Sat, 18 Mar 2000 13:34:03 -0600 From: Chris Costello To: committers@FreeBSD.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c Message-ID: <20000318133403.O24374@holly.calldei.com> Reply-To: chris@calldei.com References: <200003180127.RAA26576@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii User-Agent: Mutt/0.96.4i In-Reply-To: <200003180127.RAA26576@freefall.freebsd.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Friday, March 17, 2000, Chris Costello wrote: > Log: > In vn_isdisk(), check whether vp->v_rdev is NULL. If it is, then > return ENXIO (Device not configured). Without this, vn_isdisk() > could (and did in the case of lstat() under fdesc) pass a NULL pointer > to devsw(), which caused a page fault. I'd like to MFC this tonight (Saturday night, US, CST, etc.) unless there's a reason not to. Does anyone have any objections to this change going into 4.X? -- |Chris Costello |Bad style destroys an otherwise superb program. `----------------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message