From nobody Wed Mar 25 01:29:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgTqB0stVz6WV9J for ; Wed, 25 Mar 2026 01:29:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgTq95Pwyz3Sfn for ; Wed, 25 Mar 2026 01:29:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774402197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y1Wk4Fc1afj1sxoDjhWT4/M3wK+RMKid+G5hFH91a/0=; b=p+yX3dZG3qXudKZnmHlyJRPvGANK2GQ8y4qu6wz9rwac+xRdZQjpQb52v2wFk3Q7exLqxT caiO/59qMBQA2cmKrmG2bE/Kmo0kUx2gnpOBdmP4hL1GukRwlp3l6E21XcHoEvIfEIwT34 fUxMZ3kgD3MCB0vvOZrJD41ZOSlxcNji8l1lCkZyfPmjnIHYDTIQrCbYdDqkdMVK6kS/oH DXQGjAhO1ajDClfcR75AEwvkPEYVLtjfGFiOvi3FXqUq0J3sQwrjafpY9YA8mbjLHHrkZQ 4kHS1FMTVx52wVvCTAVk2rNmD5q+bsYgQpba+b3St/eTf7or4vQFdZkzKQyXLA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774402197; a=rsa-sha256; cv=none; b=kMmENEr2oZ6UzznGuES9jU5nvYk3a16mIqQvbzB0dbISkJegsMv0BIQBh6+XDN7Wk0+hQf Nn3He2oYkNj2aJirUF0913dLK0ugX4+yfsfFTqgTuPnavJTkWRQz0CeT6efcVwgxFt2Tcu 5FEkaIPS5Hai8fv5irwZ1GtiX4T6j9iY76EbRVV9AYnrbgVTmBBwpbixP76ITOBGlOCQe+ 2i8FCq/hThNTymHrF5oK03sYK6Pw+76XNa2qi8u3jWgQkcqmsBvFoYyggd9li+4WKPjFHQ 2mdl3/bHwPCxEffQYjf3pqZeK4nUKoz/R0qNEXLg+penI9OyGcCnAAe5rxtw6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774402197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=y1Wk4Fc1afj1sxoDjhWT4/M3wK+RMKid+G5hFH91a/0=; b=NhvKf/jDrCGZNA+GzOIrFr0eB77/K0QxMr+2g2WDuNTrypMp5ebCaA0JCwUJbAU5IS0ZgP wtyBX8KT7x8bG+9H7ZDfx6ihRX9Mm8WqSaVJJlKF7AmKtz5StFIfJlOHiXcs79T+/i9hv/ H55XGue7l4AdNgnOXsnZxTXU3Odk7QJVRYjmaLn6Ynorv25yylM3EuxVo3R0WkKFj7fSHA ujlk2gOyMgL/Bg8oWY5ik6Dek7X7g7K9Off+wCDAq2uVABrU3GDB2G7Vn3rjsHZPJ+SX6w XVM+PkBcbyqSfMAmGiFHYV+37V830jjRBGJGjltjRYumeHpnj1nM7hRkaQJY/g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fgTq94vrgzkV8 for ; Wed, 25 Mar 2026 01:29:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 192a0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 25 Mar 2026 01:29:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Christos Longros From: Adrian Chadd Subject: git: 930a790c2abb - main - rge: make rx_process_limit a sysctl tunable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 930a790c2abb3680a3449a1f9ce2eff2be7acc36 Auto-Submitted: auto-generated Date: Wed, 25 Mar 2026 01:29:57 +0000 Message-Id: <69c33a95.192a0.4d7236e0@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=930a790c2abb3680a3449a1f9ce2eff2be7acc36 commit 930a790c2abb3680a3449a1f9ce2eff2be7acc36 Author: Christos Longros AuthorDate: 2026-03-25 01:27:14 +0000 Commit: Adrian Chadd CommitDate: 2026-03-25 01:27:14 +0000 rge: make rx_process_limit a sysctl tunable The number of packets processed per interrupt was hardcoded to 16. Add a per-interface sysctl dev.rge.%d.rx_process_limit tunable so users can adjust this value at runtime. Signed-off-by: Christos Longros Reviewed by: ziaee, adrian Differential Revision: https://reviews.freebsd.org/D56014 --- share/man/man4/rge.4 | 5 +++++ sys/dev/rge/if_rge.c | 3 ++- sys/dev/rge/if_rge_sysctl.c | 5 +++++ sys/dev/rge/if_rgevar.h | 2 ++ 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/share/man/man4/rge.4 b/share/man/man4/rge.4 index eea49e12af78..2b781e287e3c 100644 --- a/share/man/man4/rge.4 +++ b/share/man/man4/rge.4 @@ -147,6 +147,11 @@ tunables: .Bl -tag -width "xxxxxx" .It Va dev.rge.%d.debug Configure runtime debug output. This is a 32 bit bitmask. +.It Va dev.rge.%d.rx_process_limit +Maximum number of RX packets to process per interrupt. +The default value is 16. +Increasing this value may improve throughput on high-speed links at the +cost of increased interrupt latency. .El .Sh DIAGNOSTICS .Bl -diag diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index 5ae0b98f95a1..0007b07e0fa6 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -2099,9 +2099,10 @@ rge_rxeof(struct rge_queues *q, struct mbufq *mq) uint32_t rxstat, extsts; int i, mlen, rx = 0; int cons, prod; - int maxpkt = 16; /* XXX TODO: make this a tunable */ + int maxpkt; bool check_hwcsum; + maxpkt = sc->sc_rx_process_limit; check_hwcsum = ((if_getcapenable(sc->sc_ifp) & IFCAP_RXCSUM) != 0); RGE_ASSERT_LOCKED(sc); diff --git a/sys/dev/rge/if_rge_sysctl.c b/sys/dev/rge/if_rge_sysctl.c index a7d6e1572168..16001b4c1d94 100644 --- a/sys/dev/rge/if_rge_sysctl.c +++ b/sys/dev/rge/if_rge_sysctl.c @@ -232,6 +232,11 @@ rge_sysctl_attach(struct rge_softc *sc) "debug", CTLFLAG_RW, &sc->sc_debug, 0, "control debugging printfs"); + sc->sc_rx_process_limit = 16; + SYSCTL_ADD_INT(ctx, SYSCTL_CHILDREN(tree), OID_AUTO, + "rx_process_limit", CTLFLAG_RW, &sc->sc_rx_process_limit, 0, + "max number of RX packets to process per interrupt"); + /* Stats */ rge_sysctl_drv_stats_attach(sc); rge_sysctl_mac_stats_attach(sc); diff --git a/sys/dev/rge/if_rgevar.h b/sys/dev/rge/if_rgevar.h index d516537e6524..89d02e8acb72 100644 --- a/sys/dev/rge/if_rgevar.h +++ b/sys/dev/rge/if_rgevar.h @@ -204,6 +204,8 @@ struct rge_softc { uint32_t sc_debug; + int sc_rx_process_limit; + struct rge_drv_stats sc_drv_stats; struct rge_mac_stats sc_mac_stats;