From owner-freebsd-current@FreeBSD.ORG Tue Sep 1 21:43:45 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D5A5106566B for ; Tue, 1 Sep 2009 21:43:45 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 634058FC12 for ; Tue, 1 Sep 2009 21:43:45 +0000 (UTC) Received: from [192.168.1.4] (adsl-156-1-132.bna.bellsouth.net [70.156.1.132]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n81LhfQM089540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Sep 2009 17:43:42 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Nick Hibma In-Reply-To: <200909010931.16880.nick@van-laarhoven.org> References: <200909010931.16880.nick@van-laarhoven.org> Content-Type: text/plain Organization: FreeBSD Date: Tue, 01 Sep 2009 16:43:36 -0500 Message-Id: <1251841416.1689.4458.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: FreeBSD CURRENT Mailing List Subject: Re: Reducing noise in dmesg output X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2009 21:43:45 -0000 On Tue, 2009-09-01 at 09:31 +0200, Nick Hibma wrote: > Folks, > > dmesg is getting cluttered with random bits of irrelevant information which > either should be behind bootverbose or not at all present. Below two > locations where I intend to remove that information. The fact that a module > is loaded can be seen in the output of What is irrelevant is subjective... I mean does the average user really need to see anything in dmesg? Please don't change agp_i810.c. A verbose boot is incredibly noisy and rarely needed for debugging anything except the most deep rooted of issues. robert. > kldstat -v | grep netsmb > > the amount of stolen memory and aperture size might be interesting when > configuring your X server. Then again, most X servers nowadays HAVE no > configuration file anymore because of auto-configuration. > > Any objections? > > Nick > > Index: kern/kern_shutdown.c > =================================================================== > --- kern/kern_shutdown.c (revision 196710) > +++ kern/kern_shutdown.c (working copy) > @@ -581,6 +581,10 @@ > > /* > * Support for poweroff delay. > + * > + * Please note that setting this delay too short might power off your > machine > + * before the write cache on your hard disk has been flushed, leading to > + * soft-updates inconsistencies. > */ > #ifndef POWEROFF_DELAY > # define POWEROFF_DELAY 5000 > Index: dev/agp/agp_i810.c > =================================================================== > --- dev/agp/agp_i810.c (revision 196589) > +++ dev/agp/agp_i810.c (working copy) > @@ -474,12 +474,15 @@ > agp_generic_detach(dev); > return EINVAL; > } > - if (sc->stolen > 0) { > - device_printf(dev, "detected %dk stolen memory\n", > - sc->stolen * 4); > + if (bootverbose) { > + if (sc->stolen > 0) { > + device_printf(dev, > + "detected %dk stolen memory\n", > + sc->stolen * 4); > + } > + device_printf(dev, "aperture size is %dM\n", > + sc->initial_aperture / 1024 / 1024); > } > - device_printf(dev, "aperture size is %dM\n", > - sc->initial_aperture / 1024 / 1024); > > /* GATT address is already in there, make sure it's enabled */ > pgtblctl = bus_read_4(sc->sc_res[0], AGP_I810_PGTBL_CTL); > @@ -664,9 +667,11 @@ > gtt_size += 4; > > sc->stolen = (stolen - gtt_size) * 1024 / 4096; > - if (sc->stolen > 0) > - device_printf(dev, "detected %dk stolen memory\n", sc->stolen * 4); > - device_printf(dev, "aperture size is %dM\n", sc->initial_aperture / 1024 > / 1024); > + if (bootverbose) { > + if (sc->stolen > 0) > + device_printf(dev, "detected %dk stolen memory\n", sc->stolen * 4); > + device_printf(dev, "aperture size is %dM\n", sc->initial_aperture / 1024 > / 1024); > + } > > /* GATT address is already in there, make sure it's enabled */ > pgtblctl = bus_read_4(sc->sc_res[0], AGP_I810_PGTBL_CTL); > Index: netsmb/smb_dev.c > =================================================================== > --- netsmb/smb_dev.c (revision 196589) > +++ netsmb/smb_dev.c (working copy) > @@ -352,7 +352,6 @@ > } > clone_setup(&nsmb_clones); > nsmb_dev_tag = EVENTHANDLER_REGISTER(dev_clone, nsmb_dev_clone, 0, 1000); > - printf("netsmb_dev: loaded\n"); > break; > case MOD_UNLOAD: > smb_iod_done(); > @@ -363,7 +362,6 @@ > drain_dev_clone_events(); > clone_cleanup(&nsmb_clones); > destroy_dev_drain(&nsmb_cdevsw); > - printf("netsmb_dev: unloaded\n"); > break; > default: > error = EINVAL; > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- Robert Noland FreeBSD