Date: Tue, 10 Oct 2023 13:50:59 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices Message-ID: <bug-262032-7788-ZL8kun5wJp@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-262032-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-262032-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262032 --- Comment #10 from Robert Clausecker <fuz@FreeBSD.org> --- (In reply to Karl Bonde Torp from comment #9) Hi Karl, > I think the way to go for the architectures is using an "ONLY_FOR_ARCHS= =3D amd64", > since this is the only thing we are currently testing - which is also why= we > haven't found the issues you're seeing. Please don't do that. If people were to generally only enable packages for architectures they personally tested, rare architectures like riscv64 would receive barely any packages at all. Only set ONLY_FOR_ARCHS if you know th= at the package will only work for the listed architectures. That you didn't t= est for others doesn't mean it won't work on these. You can always mark indivi= dual architectures as broken when problems are discovered, but unless known not = to be the case, you should presume that your code works on any architecture. > For both the Manpages and bash completions I will have to do some work u= pstream to improve the flexibility of our `meson.build` file. Sounds great. We can temporarily commit the port without this flexibility = and later update it with new options if you like. > In the latest patch I did put "OPTIONS_SUB=3D yes". The section =C2=A7 5.= 14.3.1 Porter's Handbook is not very detailed, but it seems that I have don= e everything that is needed? That's half the game. This option causes placeholders like %%TESTS%% to be defined. You need to tag each file in pkg-plist with what option causes it= to be installed by placing the placeholder right in front. Only files for whi= ch the appropriate option is on are then shipped. E.g. do %%TESTS%%bin/xnvme_tests_buf to only install this file in case the TESTS option is set. (For DOCS, the placeholder is %%PORTDOCS%% for historical reasons). It is okay if your bu= ild scripts install files that you don't want to keep, as long as they are list= ed for some (possibly currently disabled) option in pkg-plist. Such files won= 't be included in the package. However, it's of course better if you try to a= void doing so. > I believe that installing both CLI tools and libraries is a sane default,= and I don't believe there is any reason to split them up into two ports at= the moment. Okay, then let's go with that. > As you point out, this is available online - and I don't think there is a= need to include this in the port. Sure, but please be mindful of users who lack internet access for some reas= on.=20 Your tools look like they will be particularly useful for systems recovery = and maintenance, which are typical scenarios where this might be the case. > I will submit a new patch at that point, thanks for all your help! Looking forwards to that and thanks for all the work. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-262032-7788-ZL8kun5wJp>