Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Oct 2002 12:57:33 +0100
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        Nate Lawson <nate@root.org>
Cc:        Bill Fenner <fenner@research.att.com>, freebsd-current@freebsd.org
Subject:   Re: libfetch(3) patch for SSL
Message-ID:  <xzpsmyo2l76.fsf@flood.ping.uio.no>
In-Reply-To: <Pine.BSF.4.21.0210292317400.89254-100000@root.org> (Nate Lawson's message of "Tue, 29 Oct 2002 23:23:23 -0800 (PST)")
References:  <Pine.BSF.4.21.0210292317400.89254-100000@root.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson <nate@root.org> writes:
> May I humbly propose that the API is broken and should be reworked?  My
> frustration with cached_connection common/ftp sharing and this thrashing
> trying to overload the return value are signs that the API needs
> rethinking.

What do you mean "overload the return value"?  _fetch_read(),
_fetch_write() and _fetch_writev() are meant to return the same values
in the same cases as read(2), write(2) and writev(2) would.  The only
difference should be in what value errno can have after they return (I
don't think any of the system calls can set it to ETIMEDOUT).

None of this has anything to do with cached connections, and I do not
agree that caching should be done in common.c, because it relies on
information (such as login and password) which is not and should not
be available at that layer.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpsmyo2l76.fsf>