From owner-freebsd-hackers@freebsd.org Mon Jan 9 09:29:05 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AF2FCA5091 for ; Mon, 9 Jan 2017 09:29:05 +0000 (UTC) (envelope-from killing@multiplay.co.uk) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB66B12B9 for ; Mon, 9 Jan 2017 09:29:04 +0000 (UTC) (envelope-from killing@multiplay.co.uk) Received: by mail-wm0-x230.google.com with SMTP id k184so111112812wme.1 for ; Mon, 09 Jan 2017 01:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=i/NoEfST30umCpuDDMjpDO8/JyNUD+jZC2EsZEKK92c=; b=TgDgz8z9VW1N1HB/AQZjVDlUiLATkbd5yHR3Bu7Uqz3DLCDBwGvyGLROqg12JRRh1/ m3Rpng7zcFk6xJT59KO8YTGDxPAq1lGeN1Ra/3EUfy1IEgErkhtwdUJNYhNQVrdAOZbu ZJ/qSBFT8tyLNO9mrbjpUor2/6DkLBzlSTFitfGzgL6gEbQniSwA/VMM18brTYUaBDvL OfZBlEsXVJDcvpBP/56rRwyXyhjFX1YlIbcDdJEiqUOvrTOoOLfZX/GgOfsHEhgHo6AB lLfyUpYmcKMdsbRDNHFiJ1J5r6OYom0hIU1p00c4rokyMH/rC4+UhWG4ocKFHb3hNG6/ ZAkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=i/NoEfST30umCpuDDMjpDO8/JyNUD+jZC2EsZEKK92c=; b=Ot5wvPj7N5dNSbMAJs4jSFZVIUwM65RqGg37OuGMDr1muzQinkfKGc/viny7hmPuW/ 9hLyVNIIiSYDCTR3worF92Go8jPq0FBYoSKP355UxFjsj8K9wkSjHQ6dUraKVIptrWi+ Z2X0Uy+CCcQMK0MvRV8giLAXNKzmSu6HcwyHU5vYrId5gmmZsAaVJKp/IzmLJBmXlXd/ xs75JlRT72uPeiml6CcUh7ID41aKM8jkd3jwnFuMNqp1bLb/bBGN08Wp/m8dXZXHQJaZ 4PgYxgdbK4c1wMFWdYoZ7TuFtLH8z9CWMKGL/CvPEK5Z1z3SPyX+cO5ik6SrRRoS0YFE 7SSQ== X-Gm-Message-State: AIkVDXKsUgpv9cMHtOM6DGVy7lWCDPxxJeXzJ4Awst9L9gXvqg9W+zkjJMmu22KBsJCUR2iC X-Received: by 10.28.54.13 with SMTP id d13mr4405490wma.133.1483954142469; Mon, 09 Jan 2017 01:29:02 -0800 (PST) Received: from [10.10.1.58] ([185.97.61.26]) by smtp.gmail.com with ESMTPSA id n5sm17741970wmf.0.2017.01.09.01.29.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 01:29:01 -0800 (PST) Subject: Re: [PATCH] Fix "netstat -rs" To: freebsd-hackers@freebsd.org References: <1483953391-11045-1-git-send-email-sebastian.huber@embedded-brains.de> From: Steven Hartland Message-ID: <73839dec-b03d-cdae-a0b4-1e1e6453215f@multiplay.co.uk> Date: Mon, 9 Jan 2017 09:29:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483953391-11045-1-git-send-email-sebastian.huber@embedded-brains.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 09:29:05 -0000 Thanks Sebastian I've just committed this. On 09/01/2017 09:16, Sebastian Huber wrote: > Load KVM symbols early so that for example rt_stats() can use them, > otherwise we get: > > $ netstat -rs > rtstat: symbol not in namelist > --- > usr.bin/netstat/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/usr.bin/netstat/main.c b/usr.bin/netstat/main.c > index 4e4428d..f26bf57 100644 > --- a/usr.bin/netstat/main.c > +++ b/usr.bin/netstat/main.c > @@ -427,6 +427,9 @@ main(int argc, char *argv[]) > if (xflag && Tflag) > xo_errx(1, "-x and -T are incompatible, pick one."); > > + /* Load all necessary kvm symbols */ > + kresolve_list(nl); > + > if (Bflag) { > if (!live) > usage(); > @@ -507,9 +510,6 @@ main(int argc, char *argv[]) > exit(0); > } > > - /* Load all necessary kvm symbols */ > - kresolve_list(nl); > - > if (tp) { > xo_open_container("statistics"); > printproto(tp, tp->pr_name, &first);