Date: Wed, 18 Jul 2012 11:11:08 -0700 From: Sean Bruno <seanbru@yahoo-inc.com> To: Mark Johnston <markjdb@gmail.com> Cc: "freebsd-scsi@freebsd.org" <freebsd-scsi@freebsd.org>, Scott Long <scott4long@yahoo.com> Subject: Re: [patch] MFI should set bio_resid on command failure Message-ID: <1342635068.2924.4.camel@powernoodle.corp.yahoo.com> In-Reply-To: <20120713223720.GA51989@oddish.sandvine.com> References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> <1341938629.2573.7.camel@powernoodle.corp.yahoo.com> <1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com> <20120713223720.GA51989@oddish.sandvine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2012-07-13 at 15:37 -0700, Mark Johnston wrote:
> It seems that the analogous line is also missing from aac(4). Is the
> patch below correct? Or am I missing something?
>
> Thanks,
> -Mark
>
> diff --git a/sys/dev/aac/aac_disk.c b/sys/dev/aac/aac_disk.c
> index e4042f7..f2f6636 100644
> --- a/sys/dev/aac/aac_disk.c
> +++ b/sys/dev/aac/aac_disk.c
> @@ -334,8 +334,10 @@ aac_biodone(struct bio *bp)
> {
> fwprintf(NULL, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, "");
>
> - if (bp->bio_flags & BIO_ERROR)
> + if (bp->bio_flags & BIO_ERROR) {
> + bp->bio_resid = bp->bio_bcount;
> disk_err(bp, "hard error", -1, 1);
> + }
>
> biodone(bp);
> }
Committed at svn r238601
Sean
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1342635068.2924.4.camel>