From owner-freebsd-bugs Wed Oct 2 20: 0:21 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB88C37B401 for ; Wed, 2 Oct 2002 20:00:16 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C68D543E6E for ; Wed, 2 Oct 2002 20:00:15 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9330FCo073558 for ; Wed, 2 Oct 2002 20:00:15 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9330Fv5073557; Wed, 2 Oct 2002 20:00:15 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EDC437B401; Wed, 2 Oct 2002 19:57:09 -0700 (PDT) Received: from tomts26-srv.bellnexxia.net (tomts26.bellnexxia.net [209.226.175.189]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7082A43E42; Wed, 2 Oct 2002 19:57:08 -0700 (PDT) (envelope-from matt@gsicomp.on.ca) Received: from xena.gsicomp.on.ca ([65.95.176.54]) by tomts26-srv.bellnexxia.net (InterMail vM.5.01.04.19 201-253-122-122-119-20020516) with ESMTP id <20021003025704.BWSM21425.tomts26-srv.bellnexxia.net@xena.gsicomp.on.ca>; Wed, 2 Oct 2002 22:57:04 -0400 Received: from dhcp2.gsicomp.on.ca (dhcp2.gsicomp.on.ca [192.168.0.11]) by xena.gsicomp.on.ca (8.11.3/8.11.3) with ESMTP id g931b7p12145; Wed, 2 Oct 2002 21:37:07 -0400 (EDT) (envelope-from matt@dhcp2.gsicomp.on.ca) Received: (from matt@localhost) by dhcp2.gsicomp.on.ca (8.12.6/8.12.6/Submit) id g932v3tu000683; Wed, 2 Oct 2002 22:57:03 -0400 (EDT) (envelope-from matt) Message-Id: <200210030257.g932v3tu000683@dhcp2.gsicomp.on.ca> Date: Wed, 2 Oct 2002 22:57:03 -0400 (EDT) From: Matt Emmerton Reply-To: Matt Emmerton To: FreeBSD-gnats-submit@FreeBSD.org, brian@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/43610: static-ize some symbols in digi driver Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 43610 >Category: kern >Synopsis: static-ize some symbols in digi driver >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 02 20:00:15 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Matt Emmerton >Release: FreeBSD 5.0-CURRENT i386 >Organization: GSI Computer Services >Environment: System: FreeBSD laptop.gsicomp.on.ca 5.0-CURRENT FreeBSD 5.0-CURRENT #5: Mon Sep 23 21:24:44 EDT 2002 root@laptop.gsicomp.on.ca:/usr/obj/usr/src/sys/LAPTOP.20020914.01 i386 >Description: PKH's JKH TODO List - kernel orphan symbol review This patch makes some symbols in the digi driver 'static', much like how the Xr.*.h files already are. >How-To-Repeat: >Fix: --- sys/dev/digi/CX.bios.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/CX.bios.h Wed Oct 2 22:44:44 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/CX.bios.h,v 1.1 2001/05/02 01:08:01 brian Exp $ */ -const u_char CX_bios[] = { +static const u_char CX_bios[] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x40, 0x28, 0x23, 0x29, 0x68, 0x6f, 0x73, 0x74, 0x62, 0x69, 0x6f, 0x73, 0x2e, 0x61, 0x73, --- sys/dev/digi/CX.fepos.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/CX.fepos.h Wed Oct 2 22:44:54 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/CX.fepos.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char CX_fepos[] = { +static const u_char CX_fepos[] = { 0x4f, 0x53, 0x31, 0x5f, 0xe9, 0xf9, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x63, 0x78, 0x66, --- sys/dev/digi/CX_PCI.bios.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/CX_PCI.bios.h Wed Oct 2 22:44:57 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/CX_PCI.bios.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char CX_PCI_bios[] = { +static const u_char CX_PCI_bios[] = { 0x4f, 0x53, 0x73, 0xee, 0x53, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xa1, 0x43, 0xa4, 0x18, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x63, 0x78, 0x70, --- sys/dev/digi/CX_PCI.fepos.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/CX_PCI.fepos.h Wed Oct 2 22:45:05 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/CX_PCI.fepos.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char CX_PCI_fepos[] = { +static const u_char CX_PCI_fepos[] = { 0x4f, 0x53, 0x90, 0xa8, 0x69, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xb8, 0x80, 0x39, 0x7b, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x63, 0x78, 0x70, --- sys/dev/digi/EPCX.bios.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/EPCX.bios.h Wed Oct 2 22:45:12 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/EPCX.bios.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char EPCX_bios[] = { +static const u_char EPCX_bios[] = { 0x4f, 0x53, 0x71, 0x3e, 0x53, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x9b, 0xd0, 0x3c, 0x48, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x66, 0x78, 0x62, --- sys/dev/digi/EPCX.fepos.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/EPCX.fepos.h Wed Oct 2 22:45:19 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/EPCX.fepos.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char EPCX_fepos[] = { +static const u_char EPCX_fepos[] = { 0x4f, 0x53, 0x8f, 0xe5, 0x69, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x30, 0xd2, 0xe1, 0x6a, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x66, 0x78, 0x66, --- sys/dev/digi/EPCX_PCI.bios.h.orig Wed Oct 2 22:44:24 2002 +++ sys/dev/digi/EPCX_PCI.bios.h Wed Oct 2 22:45:22 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/EPCX_PCI.bios.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char EPCX_PCI_bios[] = { +static const u_char EPCX_PCI_bios[] = { 0x4f, 0x53, 0x76, 0x7f, 0x53, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xfe, 0xee, 0x76, 0x75, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x70, 0x63, 0x69, --- sys/dev/digi/EPCX_PCI.fepos.h.orig Wed Oct 2 22:44:25 2002 +++ sys/dev/digi/EPCX_PCI.fepos.h Wed Oct 2 22:45:27 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/EPCX_PCI.fepos.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char EPCX_PCI_fepos[] = { +static const u_char EPCX_PCI_fepos[] = { 0x4f, 0x53, 0x90, 0x75, 0x69, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x79, 0xd1, 0x44, 0x9d, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x70, 0x63, 0x69, --- sys/dev/digi/Xe.bios.h.orig Wed Oct 2 22:44:25 2002 +++ sys/dev/digi/Xe.bios.h Wed Oct 2 22:45:31 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/Xe.bios.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char Xe_bios[] = { +static const u_char Xe_bios[] = { 0x28, 0x43, 0x29, 0x20, 0x43, 0x6f, 0x70, 0x79, 0x72, 0x69, 0x67, 0x68, 0x74, 0x20, 0x31, 0x39, 0x39, 0x34, 0x2c, 0x20, 0x44, 0x69, 0x67, 0x69, 0x42, 0x6f, 0x61, 0x72, 0x64, 0x20, 0x49, 0x6e, 0x63, 0x2e, 0x00, 0x00, 0x8a, 0xf8, 0x8a, --- sys/dev/digi/Xe.fepos.h.orig Wed Oct 2 22:44:25 2002 +++ sys/dev/digi/Xe.fepos.h Wed Oct 2 22:45:34 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/Xe.fepos.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char Xe_fepos[] = { +static const u_char Xe_fepos[] = { 0x4f, 0x53, 0x18, 0x80, 0xe9, 0xbf, 0x15, 0x00, 0x40, 0x28, 0x23, 0x29, 0x46, 0x45, 0x50, 0x4f, 0x53, 0x20, 0x37, 0x2e, 0x30, 0x38, 0x20, 0x34, 0x2f, 0x32, 0x30, 0x2f, 0x39, 0x35, 0x00, 0x40, 0x28, 0x23, 0x29, 0x28, 0x43, 0x29, 0x43, --- sys/dev/digi/Xem.bios.h.orig Wed Oct 2 22:44:25 2002 +++ sys/dev/digi/Xem.bios.h Wed Oct 2 22:45:38 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/Xem.bios.h,v 1.1 2001/05/02 01:08:02 brian Exp $ */ -const u_char Xem_bios[] = { +static const u_char Xem_bios[] = { 0x4f, 0x53, 0xa1, 0xb5, 0x53, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xc1, 0x26, 0xe2, 0xa6, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x73, 0x78, 0x62, --- sys/dev/digi/Xem.fepos.h.orig Wed Oct 2 22:44:25 2002 +++ sys/dev/digi/Xem.fepos.h Wed Oct 2 22:45:43 2002 @@ -27,7 +27,7 @@ * $FreeBSD: src/sys/dev/digi/Xem.fepos.h,v 1.1 2001/05/02 01:08:03 brian Exp $ */ -const u_char Xem_fepos[] = { +static const u_char Xem_fepos[] = { 0x4f, 0x53, 0x6f, 0xbe, 0x69, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x2d, 0xf9, 0x30, 0x6b, 0x00, 0x00, 0x00, 0x00, 0x40, 0x28, 0x23, 0x29, 0x73, 0x78, 0x66, >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message