From nobody Wed Mar  8 20:52:27 2023
X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PX4JM2zCpz3wsNH;
	Wed,  8 Mar 2023 20:52:35 +0000 (UTC)
	(envelope-from j@uriah.heep.sax.de)
Received: from uriah.heep.sax.de (uriah.heep.sax.de [213.240.137.9])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4PX4JL5WXtz4B8W;
	Wed,  8 Mar 2023 20:52:34 +0000 (UTC)
	(envelope-from j@uriah.heep.sax.de)
Authentication-Results: mx1.freebsd.org;
	none
Received: by uriah.heep.sax.de (Postfix, from userid 107)
	id 35765499A; Wed,  8 Mar 2023 21:52:27 +0100 (CET)
Date: Wed, 8 Mar 2023 21:52:27 +0100
From: Joerg Wunsch <j@uriah.heep.sax.de>
To: Kyle Evans <kevans@freebsd.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
	dev-commits-src-main@freebsd.org
Subject: Re: git: 175a584e501e - main - usb: dwc3: add <sys/mutex.h>
Message-ID: <ZAj1i7VTdUR2+USO@uriah.heep.sax.de>
Reply-To: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>
References: <202303082001.328K1iMn005869@gitrepo.freebsd.org>
 <CACNAnaHC0nM+sggOjw7PA_zZOMPN8Tyy4u-L2kJnQMK_OMzxUg@mail.gmail.com>
 <ZAju6PJHo5OlD9tE@uriah.heep.sax.de>
 <CACNAnaGUeXEyMhK7sm5HpX195agA6uw2M_T2YeHeLPDucEK5oQ@mail.gmail.com>
List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main
List-Help: <mailto:dev-commits-src-main+help@freebsd.org>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-main@freebsd.org
X-BeenThere: dev-commits-src-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACNAnaGUeXEyMhK7sm5HpX195agA6uw2M_T2YeHeLPDucEK5oQ@mail.gmail.com>
X-Phone: +49-351-2012 669
X-GPG-Fingerprint-1: 5E84 F980 C3CA FD4B B584  1070 F48C A81B 69A8 5873
X-GPG-Fingerprint-2: 5662 8323 218C 669F F578  705C 7E9E ADC3 030D 34EB
X-Rspamd-Queue-Id: 4PX4JL5WXtz4B8W
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:8820, ipnet:213.240.128.0/18, country:DE]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

As Kyle Evans wrote:

> > sys/dev/dpaa2/dpaa2_mc.c fails to compile since LA_UNLOCKED is
> > undefined. This is aliased to MA_NOTOWNED in <sys/mutex.h>.
> >
> > Sure, I can get it to compile by adding <sys/lock.h> to that file, but
> > I don't see why it could ever compile at all.  OTOH, wouldn't it make
> > sense that <sys/mutex.h> itself included <sys/lock.h>?
> >
> 
> It looks like it's getting it via pollution from ACPI headers or from
> sys/mutex.h -> sys/lock_profiling.h -> sys/lock.h with LOCK_PROFILING
> enabling.
> 
> It would make sense, but we've only semi-recently started considering
> making headers self-contained.

OK, thanks for the analysis.

As adding <sys/lock.h> to dpaa2_mc.c fixes the compile issue, and got
me a complete kernel compilation on arm64, I just committed it that
way.  If someone sees a better way, it's also fine - as it is, it
seemed the least intrusive option to me. (Just affects one file, while
touching <sys/mutex.h> would touch the entire kernel.)

-- 
cheers, Joerg               .-.-.   --... ...--   -.. .  DL8DTL

http://www.sax.de/~joerg/
Never trust an operating system you don't have sources for. ;-)