From owner-freebsd-ports@freebsd.org Sun Jul 7 10:12:55 2019 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EC8515E12DE for ; Sun, 7 Jul 2019 10:12:55 +0000 (UTC) (envelope-from idefix@fechner.net) Received: from anny.lostinspace.de (anny.lostinspace.de [IPv6:2001:608:a02::33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6C30177E0A for ; Sun, 7 Jul 2019 10:12:54 +0000 (UTC) (envelope-from idefix@fechner.net) Received: from server.idefix.lan (unknown [IPv6:2a01:5c0:1a:31d1:21b:21ff:fe7b:3468]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 36EDD8AE7E for ; Sun, 7 Jul 2019 12:12:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fechner.net; s=default; t=1562494372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp:autocrypt:autocrypt; bh=P2NUEI/waKUKUFP++IGZuzaO/NzWnQWZs+egmLxJIJc=; b=J2H7OGBN0IS+tXF9SKMbFLU5IQjQgf/8qgeUWmJ1iIbBQxMuBeB9rk6D4O/WgJmhVZVv/4 k6dJE320LLGc0wXWVSt4c875kB0F0nMR1KS8iaCJZ03oYAngPfioGzlthFrP2Fm2S5dha0 zpHHeFzBCQ9MuuUO/nhHOSOTOXLfQl4= Received: from [192.168.0.151] (231-155-117-131.ip-addr.inexio.net [131.117.155.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by server.idefix.lan (Postfix) with ESMTPSA id 685B948744C for ; Sun, 7 Jul 2019 12:12:50 +0200 (CEST) Subject: Re: How to handle go dependencies To: freebsd-ports@freebsd.org References: <5d0e8e03.1c69fb81.5e249.9640@mx.google.com> <20190622205205.GB40599@xombo.localdomain> <4de2a97c-8c41-74e4-cda1-4fdec9554e8f@fechner.net> <20190623095737.GA89814@urd.tobik.me> <20190623214048.GE40599@xombo.localdomain> <07e99b4c-cf7e-49bb-d0a0-66a24c3a563f@fechner.net> <20190706194835.GA86243@xombo.localdomain> <52f3b04f-bf8d-0ec3-e3de-32c6d3a39485@fechner.net> <20190706221001.GB86243@xombo.localdomain> From: Matthias Fechner Openpgp: preference=signencrypt Autocrypt: addr=idefix@fechner.net; prefer-encrypt=mutual; keydata= mQINBFqca1YBEADM9mF2+ifk8HILTlf5wtAzV6SYVR4RvNOo/8Kucw4sCZT76zS1fjZe4Zy1 3C0IZ07Wi+3PnoGIgOCsXp3PrTc2nuHQWkwVBYXy8UaR9DHBWA/mIvRGG1ZscKQYA6oUdCvd K8Mu26zO60yTt+ONzFtK6G1myH4EHXZ8dpmdCFf+W3rzTU+aCQ5S3OfwCLGgYgOaVREGkdOc 5SVCpFb4n+2B8+CqeWsRHhnT+4h7/YhgDMGp4GiI3yrB2nBVSUUvcosD2nRtJQgGQHcAFtMq 3hJaKPOR/mHc6KVrp0xmGNmdtazvXloHmGIl9O1UpmMmrYu9Kugl0JkGi2fAcno02XgVlkyX 7xDLTteP5cNqRxor4yVDaRWUQnOfK9XgcrKGrAzb65BkCSkjT+Aw3S/A8Qd6NvjL9qy1d+Ct dzatOVF/Y7jaW28CMr3jvwPS13OxV7PnJzIZzdik20eVxfOXuYfxZD+PwBaGgFF0qj6zKACC aKLalE0ZpY0zNn/iPyQX/Cf9KoDyFpOHSsEswiJ5rCWwppVcsFyogHOemVmeaXlvyDPEipnV ZUkpGP/CCqPu3eD0uDzP7UJ0pt/l/JfW0Xw/4p9mjB024xiRlxLa6vSRfGl//EdtAIbKKa8x 5wsKTQEbYJDmXE3tH/A54DCqRXhcopTlu2iJlTdnIMltn9afVwARAQABtCVNYXR0aGlhcyBG ZWNobmVyIDxpZGVmaXhAZmVjaG5lci5uZXQ+iQJXBBMBCgBBAhsDBQkJZgGABQsJCAcDBRUK CQgLBRYDAgEAAh4BAheAFiEEaWB64mCp804YOtqutot13J/XR+EFAlqcc9gCGQEACgkQtot1 3J/XR+GQyhAAwDxUSg7X2aS1d6rrYUZdDk8rT5TCjayDAyOATdAUhJRZk8qXRNF27Mu6xiOT mIvEMKLagNsitffZs1g/mulRQiDVLloGav7xozSfYlaOYWpPb55wpsugQPLZz0OkU9tzw7j7 7sPPvnAxeqSofUJzQdZzp43aVwXVqsJ3rY0jGzYA5RLS6CBI1RRR8/hHLMxspDPl79IW3GhI HAXaVX1HVJA2oJEo9Y95DnJwX8NV+hvLlUVA2KDdNKFiVJKeV3ccqw+/5zW3Y8J6Rd8blW9n p68Z7lyxt6mvsDEdSxOyGSkPagzIDfHqmDfkaeum7gHMwweH2e2pZuhzMZkrKNoSkKiJ5uim 638ZhnzzmEWh2qtYPgHlZG1jO6n2DSzCqJkQYjYUtLj7ylIgZakG8M3idQRugHImMBq+HSMu WR8FI52gh1+4LbIArHB4YWTTr933ElwhS1jtomK9SeWezPfjunpxqXQl4QR0qXAuglsOMJ6y Togb6lc0qyEdOa5VCXQTLSD9yZpolSQOjOe1XEyM4g5v7FrPBGVni9AxlARvUDVbYQDv1+4A gchtgpLmAF8mDPq/tGeXuAO3m+ExQDXpJ4CneI9YHc+joU2cXQi5MP1NzgMOV43XEZCiTW0O BWM1+857gmDqGbybE7F3UFpvBs9/NRWnuxoKaYxYbqCOc3m5Ag0EWpxrVgEQAN3uCLHZF+1V gcrzYjwL1wAJwjYb7UnHKvNYdaBKgW0n0NTfaTCLHxHYPO8NlV1+lNctSeXLeiWpmE1lCDHq /++53EJ34OsRd/n246PdtfIfltML73tsmq6S9zTye2zv7LsmE7jgUBaasbv0qSLSybOUvkRx j3xBuK9Ymg/ZXaENOhxwIQ6oQoNLg3ers9t5Xl4NVK6gzzZ2OdTGnuUVhQmi4rbP04R0GJFh AtGLAYUCxlXVZhdPAs4qZaoAEP5nW/u2MyzSaIouwcEIdttAiPZdrJr+a4OGKz88Sn6zqKSa uyUADgX+G8tKUONgZbfz4SSRvlinOgyU2RyyfNS977r/YfaHH+oAxg31yUWPtD/ryfVw69bG vK8RQrZ9+c1vyWBABoQOh5+JHW/AE9Xj5dQatEfWmGO3+/FRo2TIhqZQXXl8PW+jtEjkhgOH OUX5ERzSm6nCcPIw+LUkEINcLc9bw4fv1eOWIdBuCckGM4rWXkLYbqhdSzdWeCsC0tiQk8x7 O1zXRJOKF4rITJd/qX322EH29BR+T9V1Hw7LDSRe+3YxtoXhROZRXjF8QniEHeKVNRUComr6 rWGmuHjsNTQ7twtwnG8xSOfCkYAp9GrbzBkIYX+VFvFQLqVM+It3RAlge/bwpZPvkr3bFsJk 4JS+EAugBIrP0xd9BMOh6Ej5ABEBAAGJAjwEGAEKACYWIQRpYHriYKnzThg62q62i3Xcn9dH 4QUCWpxrVgIbDAUJCWYBgAAKCRC2i3Xcn9dH4ZZsEACoQI109htphVe2AQhJ7wuPo8pIrSFA 0Mb0pfibX/sYw8ZZz/x3ctTI3Ajq2baSaoebIuUyd6oPI7cAzgL4s2zHiZ3ChH2dDxJlOPfk OaiK124DJMPqWiWuxe39tgq23tsPhwcvF+DC+SkJoLWKCYNC06fS3bLktZ0s4lVE5tqfL5ww MvxgxB+6+sWHwZWSv1IwB/geov6zkEhVdkXqrGPE52LyLfU0ACMmihcl0/npsCMZSls0urge CsPMuHPQnmcM2ERbere8i9OdKQDzGBrTbWl9DxNRf4o+cAYirEJM3Kc+ZD2SE34bTSvg3kdQ QZQbj+o+BRcsR0LaGbORkNaMZlp5OuXteL6nG7sbAPn0bjUUlup8CJEXDXENG6LJG1/oVWFq m3OtPyr5UoMQAuhuGx0/Om6AXKr/mk+veuoKWMXkqll045/bYE7bX2A0gkyGE5DdjaiHPmS9 NsWuKDeExLlXZOL1GX+PKjWLADwlv07XHB8Hf6U0/lpf3/mggRtqHyKbHt0iRqYaMC95gVdM rbugxh61U/zxIaweU7VolD5cRrltxqPp5szOwDzw42JYwbpYsXFJXNkuCGCmK1LHcShfEggt fV3g/JKzvNRQn6p1f0frppl/eZ5UvWVKrNERJzcZgkOecxwiK/L/JoGpGfWOqWGsTxe/AnQc Xxj8Dw== Message-ID: Date: Sun, 7 Jul 2019 12:12:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190706221001.GB86243@xombo.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: de-DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=fechner.net; s=default; t=1562494372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp:autocrypt:autocrypt; bh=P2NUEI/waKUKUFP++IGZuzaO/NzWnQWZs+egmLxJIJc=; b=o8p+VAB8GMtiaePI2EfrD5hIjmpa4J4lOm8H0FuvoY0PZxgIFlPuoRarK2IDhoHFvBAw0b saerWZh062WRmr5pAEuV6VQTdoUeAr83TKjy0iEmLEGQLzQhoRCBkmsT+3tWKriMXu69IV OUELuTo/ROK1oHRnfVi6J7ntkiKnEMQ= ARC-Seal: i=1; s=default; d=fechner.net; t=1562494372; a=rsa-sha256; cv=none; b=kdwL3sAorboL3FPmCIbd/o4PEWmu6z0hEknrpnYa08Me3iZrbXEKPC3av3BWiY2iyJva6t TXE1OieUOplUtSCaUgbtIelEMwFQPoRJEksYuwWx8Ez0StxB5s+cWfNp2rbIqMLkaCMWh1 rZ5HVSgbkenATqRxjyNOhDrnaWM0OFQ= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=idefix@fechner.net smtp.mailfrom=idefix@fechner.net X-Spamd-Bar: --- Authentication-Results: ORIGINATING; auth=pass smtp.auth=idefix@fechner.net smtp.mailfrom=idefix@fechner.net X-Rspamd-Server: anny.lostinspace.de X-Rspamd-Queue-Id: 36EDD8AE7E X-Spamd-Result: default: False [-3.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-3.00)[100.00%]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_SIGNED(0.00)[i=1]; DKIM_SIGNED(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12874, ipnet:2000::/3, country:IT]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jul 2019 10:12:55 -0000 Dear Dmitri, Am 07.07.2019 um 00:10 schrieb Dmitri Goutnik via freebsd-ports: > It appears that Go build flags need to be passed down to `go build` invocation > with MAKE_ENV: > > +MAKE_ENV= GOFLAGS="${GO_BUILDFLAGS}" > > With that change, the build then fails later due to missing statFileSystemType > func definition for freebsd: > > # gitlab.com/gitlab-org/gitaly/internal/helper/fstype > internal/helper/fstype/fstype.go:7:15: undefined: statFileSystemType > > Which can be fixed by just copying the linux version (this probably needs to > be upstreamed): > > post-patch: > ${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|" ${WRKSRC}/config.toml.example > ${MV} ${WRKSRC}/config.toml.example ${WRKSRC}/config.toml.sample > + ${CP} ${WRKSRC}/internal/helper/fstype/detect_linux.go ${WRKSRC}/internal/helper/fstype/detect_freebsd.go thanks a lot for your help! Without your help the upgrade to www/gitlab-ce 12.0.3 would not have been possible. This go stuff is really not that simple. I reported the upstream change here: https://gitlab.com/gitlab-org/gitaly/issues/1768 Gitlab-ce 12.0.3 is now commited ;) Thanks again. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook