From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 15 16:20:14 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0B1316A4CE for ; Mon, 15 Mar 2004 16:20:14 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FA5843D31 for ; Mon, 15 Mar 2004 16:20:14 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i2G0KEbv003057 for ; Mon, 15 Mar 2004 16:20:14 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i2G0KErx003056; Mon, 15 Mar 2004 16:20:14 -0800 (PST) (envelope-from gnats) Date: Mon, 15 Mar 2004 16:20:14 -0800 (PST) Message-Id: <200403160020.i2G0KErx003056@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Oliver Eikemeier Subject: Re: ports/64317: Update of german/BBBike port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Oliver Eikemeier List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2004 00:20:14 -0000 The following reply was made to PR ports/64317; it has been noted by GNATS. From: Oliver Eikemeier To: slaven@rezic.de Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/64317: Update of german/BBBike port Date: Tue, 16 Mar 2004 01:19:50 +0100 Slaven Rezic wrote: > Oliver Eikemeier writes: > >>> .include >>>+ >>>+.if !defined(PERL_VER) || ${PERL_VER} == 5.005 >>>+PLIST= ${PKGDIR}/pkg-plist.5005 >>>+LOCAL_PERL_ARCH!=${PERL5} -MConfig -e 'print qq{$$Config{archname}}' >>>+.else >>>+LOCAL_PERL_ARCH!=${PERL5} -MConfig -e 'print qq{$$Config{version}/$$Config{archname}}' >>>+.endif >> >>please check your port with portlint before submitting > > I do (4 warnings, no error). It is supposed to say: FATAL: Makefile: do not include anything after bsd.port(.post).mk could you check that you have the latest version of portlint and send me the port as a shar if you still get no error? >>- never write anything after bsd.port(.post).mk > > I am open to better solutions. Unfortunately I need to pass the > "LOCAL_PERL_ARCH" variable for pkg-plist generation, which in turn > needs the current value of some perl Config variables. PERL5 is only > defined after including bsd.port.mk, so this part had to go after the > include. If you got a problem like this, *please* don't hack around the port system. These things might need a lot of work to clean up. Try asking for help on perl@ and ports@. We have things like PERL_VERSION and PERL_ARCH, so it should be doable. If a variable is missing, please post this to ports, so we can fix this. >>- this will break `make describe' on systems without perl installed > > I can skip this part if perl is missing. How to detect this reliably? > By checking the existance of /usr/bin/perl5? You can't. The system might have no perl installed when the Makefile is parsed, but get perl added as dependency (because of USE_PERL5=yes). Generally, using != in ports is a bad idea. Really. Please? -Oliver