From owner-freebsd-current@FreeBSD.ORG  Wed Jul  9 08:40:06 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A2E2C37B401
	for <current@freebsd.org>; Wed,  9 Jul 2003 08:40:06 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 45D2343F93
	for <current@freebsd.org>; Wed,  9 Jul 2003 08:40:06 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 276142ED43E; Wed,  9 Jul 2003 08:40:06 -0700 (PDT)
Date: Wed, 9 Jul 2003 17:40:06 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Mark Murray <mark@grondar.org>
Message-ID: <20030709154006.GG42121@elvis.mu.org>
References: <200307091534.h69FYXbN079580@grimreaper.grondar.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200307091534.h69FYXbN079580@grimreaper.grondar.org>
User-Agent: Mutt/1.4.1i
cc: current@freebsd.org
Subject: Re: Broken ep0
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jul 2003 15:40:07 -0000

Mark Murray wrote:
> Hi
> 
> Since your last round of changes to if_ep.c (up to 1.117), the pccard ep0
> on my ToPIC97 based laptop is broken.
> 
> I've chatted to Warner about this, and I have a local hack where I back
> out a fix of his, and this allows the ep0 device to work (I think he said
> there was a race condition in the interrupts).
> 
> Can you have a look at this please?
> 
> The symptoms are an ep0 that works for a few packets and then completely
> stops working. It doesn't respond to pings, nothing.

I think you and/or Warner got mistaken.  My last round of changes to
if_ep.c _fixed_ some race conditions that previously weren't a problem,
but became a problem once Warner flag'd the pccbb interrupts
INTR_MPSAFE.  It's very possible that there are other problems left in
the ep(4) driver, but I highly doubt my changes to if_ep.c are the
culprit.  I'm sorry but I can't do anything for you since I don't even
have ep(4) hardware here ; I was able to fix the race conditions
mentioned above because people reported panics with stacktrace that made
the problem obvious.

Cheers,
Maxime